From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Libo Chen <clbchenlibo.chen@huawei.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>,
timur@freescale.com
Subject: Re: [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()
Date: Mon, 12 Aug 2013 22:10:37 +0400 [thread overview]
Message-ID: <5209251D.80902@cogentembedded.com> (raw)
In-Reply-To: <5208E215.6030007@huawei.com>
Hello.
On 08/12/2013 05:24 PM, Libo Chen wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> drivers/net/ethernet/freescale/fsl_pq_mdio.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
> diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> index c93a056..995a3ab 100644
> --- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> +++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
[...]
> @@ -468,7 +468,6 @@ static int fsl_pq_mdio_remove(struct platform_device *pdev)
>
> mdiobus_unregister(bus);
>
> - dev_set_drvdata(device, NULL);
You don't mention this in the changelog.
WBR, Sergei
next prev parent reply other threads:[~2013-08-12 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 13:24 [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 18:10 ` Sergei Shtylyov [this message]
2013-08-14 3:39 ` [PATCH RESEND " Libo Chen
2013-08-14 18:54 ` Sergei Shtylyov
2013-08-15 9:27 ` Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5209251D.80902@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=clbchenlibo.chen@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).