netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()
@ 2013-08-12 13:24 Libo Chen
  2013-08-12 18:10 ` Sergei Shtylyov
  2013-08-14  3:39 ` [PATCH RESEND " Libo Chen
  0 siblings, 2 replies; 5+ messages in thread
From: Libo Chen @ 2013-08-12 13:24 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, LKML, Li Zefan, timur


Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
 drivers/net/ethernet/freescale/fsl_pq_mdio.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index c93a056..995a3ab 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -409,7 +409,7 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
 	priv->regs = priv->map + data->mii_offset;

 	new_bus->parent = &pdev->dev;
-	dev_set_drvdata(&pdev->dev, new_bus);
+	platform_set_drvdata(pdev, new_bus);

 	if (data->get_tbipa) {
 		for_each_child_of_node(np, tbi) {
@@ -468,7 +468,6 @@ static int fsl_pq_mdio_remove(struct platform_device *pdev)

 	mdiobus_unregister(bus);

-	dev_set_drvdata(device, NULL);

 	iounmap(priv->map);
 	mdiobus_free(bus);
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()
  2013-08-12 13:24 [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata() Libo Chen
@ 2013-08-12 18:10 ` Sergei Shtylyov
  2013-08-14  3:39 ` [PATCH RESEND " Libo Chen
  1 sibling, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2013-08-12 18:10 UTC (permalink / raw)
  To: Libo Chen; +Cc: David Miller, netdev, LKML, Li Zefan, timur

Hello.

On 08/12/2013 05:24 PM, Libo Chen wrote:

> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.

> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
>   drivers/net/ethernet/freescale/fsl_pq_mdio.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)

> diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> index c93a056..995a3ab 100644
> --- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> +++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
[...]
> @@ -468,7 +468,6 @@ static int fsl_pq_mdio_remove(struct platform_device *pdev)
>
>   	mdiobus_unregister(bus);
>
> -	dev_set_drvdata(device, NULL);

    You don't mention this in the changelog.

WBR, Sergei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()
  2013-08-12 13:24 [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata() Libo Chen
  2013-08-12 18:10 ` Sergei Shtylyov
@ 2013-08-14  3:39 ` Libo Chen
  2013-08-14 18:54   ` Sergei Shtylyov
  1 sibling, 1 reply; 5+ messages in thread
From: Libo Chen @ 2013-08-14  3:39 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, LKML, Li Zefan


We can use the wrapper functions platform_{get,set}_drvdata() instead of
dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.

Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
 drivers/net/ethernet/freescale/fsl_pq_mdio.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index c93a056..995a3ab 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -409,7 +409,7 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
 	priv->regs = priv->map + data->mii_offset;

 	new_bus->parent = &pdev->dev;
-	dev_set_drvdata(&pdev->dev, new_bus);
+	platform_set_drvdata(pdev, new_bus);

 	if (data->get_tbipa) {
 		for_each_child_of_node(np, tbi) {
@@ -468,7 +468,6 @@ static int fsl_pq_mdio_remove(struct platform_device *pdev)

 	mdiobus_unregister(bus);

-	dev_set_drvdata(device, NULL);

 	iounmap(priv->map);
 	mdiobus_free(bus);
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()
  2013-08-14  3:39 ` [PATCH RESEND " Libo Chen
@ 2013-08-14 18:54   ` Sergei Shtylyov
  2013-08-15  9:27     ` Libo Chen
  0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2013-08-14 18:54 UTC (permalink / raw)
  To: Libo Chen; +Cc: David Miller, netdev, LKML, Li Zefan

Hello.

On 08/14/2013 07:39 AM, Libo Chen wrote:

> We can use the wrapper functions platform_{get,set}_drvdata() instead of
> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.

> Also, unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.

    You misunderstood. That's a material for 2 separate patch sets (or maybe 
single patches, since multiple files can be collapsed in a single patch).

> Signed-off-by: Libo Chen <libo.chen@huawei.com>

WBR, Sergei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()
  2013-08-14 18:54   ` Sergei Shtylyov
@ 2013-08-15  9:27     ` Libo Chen
  0 siblings, 0 replies; 5+ messages in thread
From: Libo Chen @ 2013-08-15  9:27 UTC (permalink / raw)
  To: Sergei Shtylyov; +Cc: David Miller, netdev, LKML, Li Zefan

On 2013/8/15 2:54, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/14/2013 07:39 AM, Libo Chen wrote:
> 
>> We can use the wrapper functions platform_{get,set}_drvdata() instead of
>> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.
> 
>> Also, unnecessary dev_set_drvdata() is removed, because the driver core
>> clears the driver data to NULL after device_release or on probe failure.
> 
>    You misunderstood. That's a material for 2 separate patch sets (or maybe single patches, since multiple files can be collapsed in a single patch).
> 

 okay, thanks.


Libo

>> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> 
> WBR, Sergei
> 
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-08-15  9:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-12 13:24 [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 18:10 ` Sergei Shtylyov
2013-08-14  3:39 ` [PATCH RESEND " Libo Chen
2013-08-14 18:54   ` Sergei Shtylyov
2013-08-15  9:27     ` Libo Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).