* [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()
@ 2013-08-12 13:25 Libo Chen
2013-08-12 16:53 ` Mugunthan V N
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Libo Chen @ 2013-08-12 13:25 UTC (permalink / raw)
To: David Miller
Cc: mugunthanvnm, bigeasy, prabhakar.csengg, b-liu, netdev, LKML,
Li Zefan
Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 16ddfc3..2249b2c 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -421,8 +421,7 @@ bail_out:
static int davinci_mdio_remove(struct platform_device *pdev)
{
- struct device *dev = &pdev->dev;
- struct davinci_mdio_data *data = dev_get_drvdata(dev);
+ struct davinci_mdio_data *data = platform_get_drvdata(pdev);
if (data->bus) {
mdiobus_unregister(data->bus);
@@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- dev_set_drvdata(dev, NULL);
kfree(data);
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()
2013-08-12 13:25 [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata() Libo Chen
@ 2013-08-12 16:53 ` Mugunthan V N
2013-08-12 18:17 ` Sergei Shtylyov
2013-08-14 3:40 ` [PATCH RESEND " Libo Chen
2 siblings, 0 replies; 7+ messages in thread
From: Mugunthan V N @ 2013-08-12 16:53 UTC (permalink / raw)
To: Libo Chen
Cc: David Miller, bigeasy, prabhakar.csengg, b-liu, netdev, LKML,
Li Zefan
On Monday 12 August 2013 06:55 PM, Libo Chen wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
Looks good.
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()
2013-08-12 13:25 [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 16:53 ` Mugunthan V N
@ 2013-08-12 18:17 ` Sergei Shtylyov
2013-08-12 20:04 ` David Miller
2013-08-13 1:23 ` Libo Chen
2013-08-14 3:40 ` [PATCH RESEND " Libo Chen
2 siblings, 2 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2013-08-12 18:17 UTC (permalink / raw)
To: Libo Chen
Cc: David Miller, mugunthanvnm, bigeasy, prabhakar.csengg, b-liu,
netdev, LKML, Li Zefan
On 08/12/2013 05:25 PM, Libo Chen wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
> ---
> drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
> index 16ddfc3..2249b2c 100644
> --- a/drivers/net/ethernet/ti/davinci_mdio.c
> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
[...]
> @@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
> pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
>
> - dev_set_drvdata(dev, NULL);
Doesn't get described as well. I think you're mixing two types of changes
in one patchset.
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()
2013-08-12 18:17 ` Sergei Shtylyov
@ 2013-08-12 20:04 ` David Miller
2013-08-13 1:22 ` Libo Chen
2013-08-13 1:23 ` Libo Chen
1 sibling, 1 reply; 7+ messages in thread
From: David Miller @ 2013-08-12 20:04 UTC (permalink / raw)
To: sergei.shtylyov
Cc: clbchenlibo.chen, mugunthanvnm, bigeasy, prabhakar.csengg, b-liu,
netdev, linux-kernel, lizefan
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Mon, 12 Aug 2013 22:17:47 +0400
> Doesn't get described as well. I think you're mixing two types of
> changes in one patchset.
Agreed, you're going to have to redo this entire patch set.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()
2013-08-12 20:04 ` David Miller
@ 2013-08-13 1:22 ` Libo Chen
0 siblings, 0 replies; 7+ messages in thread
From: Libo Chen @ 2013-08-13 1:22 UTC (permalink / raw)
To: David Miller
Cc: sergei.shtylyov, mugunthanvnm, bigeasy, prabhakar.csengg, b-liu,
netdev, linux-kernel, lizefan
On 2013/8/13 4:04, David Miller wrote:
> From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Date: Mon, 12 Aug 2013 22:17:47 +0400
>
>> Doesn't get described as well. I think you're mixing two types of
>> changes in one patchset.
>
> Agreed, you're going to have to redo this entire patch set.
>
okay, I will redo!
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()
2013-08-12 18:17 ` Sergei Shtylyov
2013-08-12 20:04 ` David Miller
@ 2013-08-13 1:23 ` Libo Chen
1 sibling, 0 replies; 7+ messages in thread
From: Libo Chen @ 2013-08-13 1:23 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: David Miller, mugunthanvnm, bigeasy, prabhakar.csengg, b-liu,
netdev, LKML, Li Zefan
On 2013/8/13 2:17, Sergei Shtylyov wrote:
> On 08/12/2013 05:25 PM, Libo Chen wrote:
>
>> Use the wrapper functions for getting and setting the driver data using
>> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
>> so we can directly pass a struct platform_device.
>
>> Signed-off-by: Libo Chen <libo.chen@huawei.com>
>> ---
>> drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
>> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
>> index 16ddfc3..2249b2c 100644
>> --- a/drivers/net/ethernet/ti/davinci_mdio.c
>> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
> [...]
>> @@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
>> pm_runtime_put_sync(&pdev->dev);
>> pm_runtime_disable(&pdev->dev);
>>
>> - dev_set_drvdata(dev, NULL);
>
> Doesn't get described as well. I think you're mixing two types of changes in one patchset.
>
> WBR, Sergei
>
thanks for your attention!
Libo
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RESEND 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()
2013-08-12 13:25 [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 16:53 ` Mugunthan V N
2013-08-12 18:17 ` Sergei Shtylyov
@ 2013-08-14 3:40 ` Libo Chen
2 siblings, 0 replies; 7+ messages in thread
From: Libo Chen @ 2013-08-14 3:40 UTC (permalink / raw)
To: David Miller
Cc: mugunthanvnm, bigeasy, prabhakar.csengg, b-liu, netdev, LKML,
Li Zefan
We can use the wrapper functions platform_{get,set}_drvdata() instead of
dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.
Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 16ddfc3..2249b2c 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -421,8 +421,7 @@ bail_out:
static int davinci_mdio_remove(struct platform_device *pdev)
{
- struct device *dev = &pdev->dev;
- struct davinci_mdio_data *data = dev_get_drvdata(dev);
+ struct davinci_mdio_data *data = platform_get_drvdata(pdev);
if (data->bus) {
mdiobus_unregister(data->bus);
@@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- dev_set_drvdata(dev, NULL);
kfree(data);
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-08-14 3:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-12 13:25 [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 16:53 ` Mugunthan V N
2013-08-12 18:17 ` Sergei Shtylyov
2013-08-12 20:04 ` David Miller
2013-08-13 1:22 ` Libo Chen
2013-08-13 1:23 ` Libo Chen
2013-08-14 3:40 ` [PATCH RESEND " Libo Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).