From: Vlad Yasevich <vyasevic@redhat.com>
To: Asbjoern Sloth Toennesen <ast@fiberby.net>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtnetlink: rtnl_bridge_getlink: Call nlmsg_find_attr() with ifinfomsg header
Date: Mon, 12 Aug 2013 15:57:29 -0400 [thread overview]
Message-ID: <52093E29.5010604@redhat.com> (raw)
In-Reply-To: <1376325009-8399-1-git-send-email-ast@fiberby.net>
On 08/12/2013 12:30 PM, Asbjoern Sloth Toennesen wrote:
> Fix the iproute2 command `bridge vlan show`, after switching from
> rtgenmsg to ifinfomsg.
>
> Signed-off-by: Asbjoern Sloth Toennesen <ast@fiberby.net>
Thanks.. I've still been using an older iproute version and didn't see
this.
Reviewed-by: Vlad Yasevich <vyasevich@gmail.com>
> ---
> net/core/rtnetlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 3de7408..a043171 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -2384,7 +2384,7 @@ static int rtnl_bridge_getlink(struct sk_buff *skb, struct netlink_callback *cb)
> struct nlattr *extfilt;
> u32 filter_mask = 0;
>
> - extfilt = nlmsg_find_attr(cb->nlh, sizeof(struct rtgenmsg),
> + extfilt = nlmsg_find_attr(cb->nlh, sizeof(struct ifinfomsg),
> IFLA_EXT_MASK);
> if (extfilt)
> filter_mask = nla_get_u32(extfilt);
>
next prev parent reply other threads:[~2013-08-12 19:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 16:24 Bridge VLAN kernel/iproute2 incompatibility Asbjørn Sloth Tønnesen
2013-08-12 16:30 ` [PATCH] rtnetlink: rtnl_bridge_getlink: Call nlmsg_find_attr() with ifinfomsg header Asbjoern Sloth Toennesen
2013-08-12 19:57 ` Vlad Yasevich [this message]
2013-08-13 22:54 ` David Miller
2013-08-13 23:06 ` Vlad Yasevich
2013-08-13 23:31 ` David Miller
2013-08-14 2:10 ` Bridge VLAN kernel/iproute2 incompatibility David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52093E29.5010604@redhat.com \
--to=vyasevic@redhat.com \
--cc=ast@fiberby.net \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).