From: Ben Greear <greearb@candelatech.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: SCTP and IP_TOS
Date: Mon, 12 Aug 2013 13:51:54 -0700 [thread overview]
Message-ID: <52094AEA.9090904@candelatech.com> (raw)
In-Reply-To: <520943E2.7010408@gmail.com>
On 08/12/2013 01:21 PM, Vlad Yasevich wrote:
> On 08/12/2013 01:00 PM, Ben Greear wrote:
>> Hello!
>>
>> I notice that I read 0x2 as IP_TOS getsockopt on an SCTP socket configured
>> for streaming mode.
>>
>> Looks to me like the reason is that SCTP uses a socket type of
>> SCTP_SOCKET_TCP
>> and the ipv4/ip_sockglue.c code is only masking out ECN for SOCK_STREAM
>> types.
>>
>> Is this per design, or should the ip_sockglue.c mask out ECN for
>> SCTP_SOCKET_TCP
>> types as well?
>>
>> Thanks,
>> Ben
>>
>
> From the ip_glue perspective, you would see either SOCK_STREAM or
> SOCK_SEQPACKET.
>
> So you are trying to set tos bits on a SEQPACKET socket, ip_sockglue()
> wouldn't try preserver current ECN bits as it does for STREAM sockets.
Actually, I am just reading the TOS, and should never be setting it
at all in this particular test case. TCP connections return 0x0 in
this case, but SCTP returns 0x2.
It's a small issue, but it screwed up some sub-standard code in
my application, so that is why I noticed it.
It *could* be that my app is somehow to blame. I'll poke around
in the kernel with printk when I get a chance.
Thanks,
Ben
>
> -vlad
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2013-08-12 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 17:00 SCTP and IP_TOS Ben Greear
2013-08-12 20:21 ` Vlad Yasevich
2013-08-12 20:51 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52094AEA.9090904@candelatech.com \
--to=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).