From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org, lethal@linux-sh.org
Cc: netdev@vger.kernel.org,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Subject: Re: [PATCH] SolutionEngine SH771x: remove Ether support
Date: Wed, 14 Aug 2013 01:32:21 +0400 [thread overview]
Message-ID: <520AA5E5.5000803@cogentembedded.com> (raw)
In-Reply-To: <201308130217.03133.sergei.shtylyov@cogentembedded.com>
Hello.
On 08/13/2013 02:17 AM, I wrote:
> The 'sh_eth' driver's probe will crash as the platform code is hopelessly behind
> the platform data -- it passes PHY ID instead of 'struct sh_eth_plat_data *'.
> Even if it's fixed, the driver probe will fail as the 'struct sh_eth_cpu_data'
> indicates presence of TSU but the platform device resource for it is absent.
> Since I have no data to fix it, I think it's best to remove the erratic code.
After looking at the original driver, it seems I've got the necessary
data... but both Ether controllers seems to have shared TSU which is not yet
supported by the driver (there was a patch from Iwamatsu-san to implement it
but it hasn't been merged).
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
WBR, Sergei
prev parent reply other threads:[~2013-08-13 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 22:17 [PATCH] SolutionEngine SH771x: remove Ether support Sergei Shtylyov
2013-08-13 21:32 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520AA5E5.5000803@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).