netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: dbaryshkov@gmail.com, davem@davemloft.net,
	linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCHv2 net-next 0/6] 6lowpan: uncompress of addresses fix
Date: Wed, 14 Aug 2013 15:23:48 +0400	[thread overview]
Message-ID: <520B68C4.7030602@gmail.com> (raw)
In-Reply-To: <1376478108-3539-1-git-send-email-alex.aring@gmail.com>

On 08/14/2013 03:01 PM, Alexander Aring wrote:
> The current implementation to uncompress addresses in a 6lowpan header
> is completely broken.
>
> This patch series fixes the parsing of addresses in a 6lowpan header.
> It contains a major rewrite of the uncompress address function to parse
> the address in a correct way.
>

Could you please describe in a few words how have you tested the changes?

Small cosmetic hint: lowpan_raw_dump_inline() already has an argument to 
print debug message, so there is no need to add extra pr_debug calls 
before it to print static text.

Alex

> Changes since v2:
>   - Add tags for net-next
>   - Change commit msg in Patch 1/6 that this patch depends for the following
>     patches
>
> Alexander Aring (5):
>    6lowpan: init ipv6hdr buffer to zero
>    6lowpan: introduce lowpan_fetch_skb function
>    6lowpan: add function to uncompress multicast addr
>    6lowpan: lowpan_uncompress_addr with address_mode
>    6lowpan: handle context based source address
>
> David Hauweele (1):
>    6lowpan: Fix fragmentation with link-local compressed addresses
>
>   net/ieee802154/6lowpan.c | 284 +++++++++++++++++++++++++++++++----------------
>   net/ieee802154/6lowpan.h |  20 +++-
>   2 files changed, 203 insertions(+), 101 deletions(-)
>

  parent reply	other threads:[~2013-08-14 11:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 11:01 [PATCHv2 net-next 0/6] 6lowpan: uncompress of addresses fix Alexander Aring
     [not found] ` <1376478108-3539-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-14 11:01   ` [PATCH 1/6] 6lowpan: init ipv6hdr buffer to zero Alexander Aring
     [not found]     ` <1376478108-3539-2-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-08-14 11:06       ` Alexander Aring
2013-08-14 11:01   ` [PATCH net-next 2/6] 6lowpan: Fix fragmentation with link-local compressed addresses Alexander Aring
2013-08-14 11:01   ` [PATCH net-next 3/6] 6lowpan: introduce lowpan_fetch_skb function Alexander Aring
2013-08-14 11:49     ` Hannes Frederic Sowa
2013-08-14 11:55       ` Alexander Smirnov
2013-08-14 12:06         ` Hannes Frederic Sowa
2013-08-14 12:45         ` Alexander Aring
2013-08-14 12:47           ` Hannes Frederic Sowa
2013-08-14 12:54             ` Alexander Aring
2013-08-14 11:01   ` [PATCH net-next 4/6] 6lowpan: add function to uncompress multicast addr Alexander Aring
2013-08-14 11:01   ` [PATCH net-next 5/6] 6lowpan: lowpan_uncompress_addr with address_mode Alexander Aring
2013-08-14 11:01   ` [PATCH net-next 6/6] 6lowpan: handle context based source address Alexander Aring
2013-08-14 11:23 ` Alexander Smirnov [this message]
2013-08-14 12:41   ` [PATCHv2 net-next 0/6] 6lowpan: uncompress of addresses fix Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520B68C4.7030602@gmail.com \
    --to=alex.bluesman.smirnov@gmail.com \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-zigbee-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).