From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
roszenrami@gmail.com, dshwatrz@gmail.com,
kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, grant.likely@linaro.org,
rob.herring@calxeda.com
Subject: Re: [PATCH] drivers/net/ethernet/via/via-velocity.c: update napi implementation
Date: Thu, 15 Aug 2013 01:42:08 +0400 [thread overview]
Message-ID: <520BF9B0.80104@cogentembedded.com> (raw)
In-Reply-To: <1376490413-12067-1-git-send-email-Julia.Lawall@lip6.fr>
Hello.
On 08/14/2013 06:26 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> Drivers supporting NAPI should use a NAPI-specific function for receiving
> packets. Hence netif_rx is changed to netif_receive_skb.
> Furthermore netif_napi_del should be used in the probe and remove function
> to clean up the NAPI resource information.
> Thanks to Francois Romieu, David Shwatrz and Rami Rosen for their help on
> this patch.
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> ---
> I still don't understand the reason for choosing netif_receive_skb,
> specifically. This patch is not tested.
This driver is not the only one with the netif_rx() used with NAPI issue.
I also overlooked this when converting drivers/net/ethernet/renesas/sh_eth.c
to NAPI. I'll try to change the call and see if netperf would behave better...
WBR, Sergei
next prev parent reply other threads:[~2013-08-14 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 14:26 [PATCH] drivers/net/ethernet/via/via-velocity.c: update napi implementation Julia Lawall
2013-08-14 21:42 ` Sergei Shtylyov [this message]
2013-08-15 8:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520BF9B0.80104@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Julia.Lawall@lip6.fr \
--cc=dshwatrz@gmail.com \
--cc=grant.likely@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=romieu@fr.zoreil.com \
--cc=roszenrami@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).