From: "Carlos O'Donell" <carlos@redhat.com>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Thomas Backlund <tmb@mageia.org>,
libc-alpha@sourceware.org,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [GLIBC Patch v2] inet: avoid redefinition of some structs in kernel
Date: Fri, 16 Aug 2013 11:47:33 -0400 [thread overview]
Message-ID: <520E4995.5090101@redhat.com> (raw)
In-Reply-To: <1376558891-26221-2-git-send-email-amwang@redhat.com>
On 08/15/2013 05:28 AM, Cong Wang wrote:
> 2013-08-13 Carlos O'Donell <carlos@redhat.com>
> Cong Wang <amwang@redhat.com>
>
> * sysdeps/unix/sysv/linux/bits/in.h
> [_UAPI_LINUX_IN6_H]: Define __USE_KERNEL_IPV6_DEFS.
> * inet/netinet/in.h: Move in_addr definition and bits/in.h inclusion
> before __USE_KERNEL_IPV6_DEFS uses.
> * inet/netinet/in.h [!__USE_KERNEL_IPV6_DEFS]: Define IPPROTO_MH, and
> IPPROTO_BEETPH.
> [__USE_KERNEL_IPV6_DEFS]: Don't define any of IPPROTO_*, in6_addr,
> sockaddr_in6, or ipv6_mreq.
Cong,
Given that this is a user visible change could you please file
a glibc bugzilla bug in sourceware[1] so we can track the commit and so
that future users can reopen the bug to discuss any defects?
Then you need to add the BZ# to the ChangeLog, and whomever
commits this for you will mark it fixed in the NEWS. We should
also write up a NEWS blurb for this since it's the first explicit
header coordination of it's kind and we should highlight that
so developers take note and help us coordinate more headers.
Cheers,
Carlos.
[1] http://sourceware.org/bugzilla/
next prev parent reply other threads:[~2013-08-16 15:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 9:28 [Patch net-next v2] net: sync some IP headers with glibc Cong Wang
2013-08-15 9:28 ` [GLIBC Patch v2] inet: avoid redefinition of some structs in kernel Cong Wang
2013-08-16 15:15 ` Carlos O'Donell
2013-08-16 15:32 ` Andreas Jaeger
2013-08-16 15:44 ` Carlos O'Donell
2013-08-16 15:47 ` Carlos O'Donell [this message]
2013-08-19 1:20 ` Cong Wang
2013-08-19 18:11 ` Carlos O'Donell
2013-08-26 5:26 ` Mike Frysinger
2013-09-06 4:52 ` Carlos O'Donell
2013-09-04 17:13 ` [Patch net-next v2] net: sync some IP headers with glibc David Miller
2013-09-06 5:19 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520E4995.5090101@redhat.com \
--to=carlos@redhat.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=libc-alpha@sourceware.org \
--cc=netdev@vger.kernel.org \
--cc=tmb@mageia.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).