From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Denis Kirjanov <kda@linux-powerpc.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 1/2] net-next: sundance: Add netconsole logging support
Date: Sat, 17 Aug 2013 03:46:49 +0400 [thread overview]
Message-ID: <520EB9E9.2020200@cogentembedded.com> (raw)
In-Reply-To: <1376672417-2798-1-git-send-email-kda@linux-powerpc.org>
Hello.
On 08/16/2013 09:00 PM, Denis Kirjanov wrote:
I'd rather name the patch "sundance: add netpoll support". "net-next:"
shouldn't be there twice definitely.
> Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
> ---
> drivers/net/ethernet/dlink/sundance.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> diff --git a/drivers/net/ethernet/dlink/sundance.c b/drivers/net/ethernet/dlink/sundance.c
> index 50d9c63..2688a84 100644
> --- a/drivers/net/ethernet/dlink/sundance.c
> +++ b/drivers/net/ethernet/dlink/sundance.c
[...]
> @@ -480,6 +491,9 @@ static const struct net_device_ops netdev_ops = {
> .ndo_change_mtu = change_mtu,
> .ndo_set_mac_address = sundance_set_mac_addr,
> .ndo_validate_addr = eth_validate_addr,
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> + .ndo_poll_controller = sundance_poll_controller,
Could you align = here with the reset of initializers?
> +#endif
WBR, Sergei
next prev parent reply other threads:[~2013-08-17 0:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 17:00 [PATCH net-next 1/2] net-next: sundance: Add netconsole logging support Denis Kirjanov
2013-08-16 17:00 ` [PATCH net-next 2/2] net-next: sundance: Add myself as an maintainer Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org> Denis Kirjanov
2013-08-16 23:46 ` Sergei Shtylyov [this message]
2013-08-17 7:12 ` [PATCH net-next 1/2] net-next: sundance: Add netconsole logging support Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520EB9E9.2020200@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=kda@linux-powerpc.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).