From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v5 1/2] ARM: davinci: da850: add DT node for ethernet Date: Sun, 18 Aug 2013 22:25:13 +0530 Message-ID: <5210FC71.3010600@ti.com> References: <1376662262-21795-1-git-send-email-prabhakar.csengg@gmail.com> <1376662262-21795-2-git-send-email-prabhakar.csengg@gmail.com> <520E7377.1080808@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "Lad, Prabhakar" , DLOS , , , LKML , To: Sergei Shtylyov Return-path: In-Reply-To: <520E7377.1080808@cogentembedded.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 8/17/2013 12:16 AM, Sergei Shtylyov wrote: > Hello. > > On 08/16/2013 06:11 PM, Lad, Prabhakar wrote: > >> From: "Lad, Prabhakar" > >> Add ethernet device tree node information and pinmux for mii to da850 by >> providing interrupt details and local mac address. > >> Signed-off-by: Lad, Prabhakar >> --- >> arch/arm/boot/dts/da850-evm.dts | 5 +++++ >> arch/arm/boot/dts/da850.dtsi | 30 ++++++++++++++++++++++++++++++ >> 2 files changed, 35 insertions(+) > >> diff --git a/arch/arm/boot/dts/da850-evm.dts >> b/arch/arm/boot/dts/da850-evm.dts >> index 1f8cfdd..44f3fbc 100644 >> --- a/arch/arm/boot/dts/da850-evm.dts >> +++ b/arch/arm/boot/dts/da850-evm.dts >> @@ -96,6 +96,11 @@ >> pinctrl-0 = <&mdio_pins>; >> bus_freq = <2200000>; >> }; >> + ethernet: emac@1e20000 { > > Why label the node in the board file too? May be not required, but all other entries in da850-evm.dts have labels too. Other .dts files like am335x-bone.dts use labels too (even though they are never used in references). So I am inclined to let this be like this and if needed have all the labels removed through a separate patch - at least we remain consistent within the file that way. Prabhakar, Please mind the new e-mail address of the devicetree list. Thanks, Sekhar