From: Michal Simek <monstr@monstr.eu>
To: Libo Chen <clbchenlibo.chen@huawei.com>
Cc: David Miller <davem@davemloft.net>,
michal.simek@xilinx.com, renner@efe-gmbh.de,
Greg KH <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>
Subject: Re: [PATCH RESEND 7/8] net: xilinx_emaclite: use platform_{get,set}_drvdata()
Date: Mon, 19 Aug 2013 09:09:06 +0200 [thread overview]
Message-ID: <5211C492.8060505@monstr.eu> (raw)
In-Reply-To: <520AFC20.7050006@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
On 08/14/2013 05:40 AM, Libo Chen wrote:
>
> We can use the wrapper functions platform_{get,set}_drvdata() instead of
> dev_{get,set}_drvdata() with &of_dev->dev, it is convenient for user.
>
> Also, unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
Acked-by: Michal Simek <monstr@monstr.eu>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
prev parent reply other threads:[~2013-08-19 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 13:25 [PATCH 7/8] net: xilinx_emaclite: use platform_{get,set}_drvdata() Libo Chen
2013-08-12 13:28 ` Michal Simek
2013-08-14 3:40 ` [PATCH RESEND " Libo Chen
2013-08-19 7:09 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5211C492.8060505@monstr.eu \
--to=monstr@monstr.eu \
--cc=clbchenlibo.chen@huawei.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=renner@efe-gmbh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).