netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Network Development <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Jiri Pirko <jiri@mellanox.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h
Date: Wed, 06 Dec 2017 17:55:42 +0100	[thread overview]
Message-ID: <5212497.opIP8sI45N@bentobox> (raw)
In-Reply-To: <CAF=yD-JxdNu6eFha_V2650-UqZ3KNSzD4Oe2RLHEWd4cz1G6kA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

On Mittwoch, 6. Dezember 2017 11:42:33 CET Willem de Bruijn wrote:
> On Tue, Dec 5, 2017 at 9:35 AM, Sven Eckelmann
> <sven.eckelmann@openmesh.com> wrote:
> > This file contains the relevant information to let userspace communicate
> > with batman-adv over generic netlink. The relevant genl enums for the
> > attributes and commands have the prefix batadv_genl. Renaming this file to
> > this name therefore represents the content better and avoids confusion 
with
> > the file which will contain the packet format definitions.
> >
> > Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
> > ---
> >  MAINTAINERS                                        | 2 +-
> >  include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++---
> 
> This and the previous patch changes uapi. That might break userspace
> applications that rely on it.

I am not aware of any application because all (alfred, batctl and some gluon 
integration) of them currently ship their own copy because distribution didn't 
catch up. And this is also the reason why I want to do it now - not later.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-12-06 16:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 14:35 [RFC v2 0/6] flow_dissector: Provide basic batman-adv unicast handling Sven Eckelmann
2017-12-05 14:35 ` [RFC v2 3/6] batman-adv: Let packet.h include its headers directly Sven Eckelmann
     [not found] ` <20171205143514.4441-1-sven.eckelmann-lv6y7wLVQPlWk0Htik3J/w@public.gmane.org>
2017-12-05 14:35   ` [RFC v2 1/6] batman-adv: Change nl references to genl Sven Eckelmann
2017-12-05 14:35   ` [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h Sven Eckelmann
2017-12-06 16:42     ` Willem de Bruijn
2017-12-06 16:55       ` Sven Eckelmann [this message]
2017-12-06 16:58         ` Willem de Bruijn
2017-12-15 10:32           ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-12-15 11:48             ` Sven Eckelmann
2017-12-15 16:57               ` Willem de Bruijn
     [not found]                 ` <CAF=yD-JTfT-iOBG6KMhXv=KggoZ4tEP1fiJMiHMA_d0-wYncLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-15 17:18                   ` Sven Eckelmann
2017-12-15 17:23                     ` [B.A.T.M.A.N.] " Willem de Bruijn
2017-12-05 14:35   ` [RFC v2 4/6] batman-adv: Remove usage of BIT(x) in packet.h Sven Eckelmann
2017-12-05 14:35 ` [RFC v2 5/6] batman-adv: Convert packet.h to uapi header Sven Eckelmann
2017-12-05 14:35 ` [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers Sven Eckelmann
2017-12-05 17:19   ` Tom Herbert
2017-12-06 10:26     ` Sven Eckelmann
2017-12-06 16:54       ` Willem de Bruijn
2017-12-06 17:10         ` Tom Herbert
     [not found]         ` <CAF=yD-LR5WSQt5jwN-+T-1iWyrxovk0qZ1cb-QUO6_+Wy8Ci-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-06 17:27           ` Sven Eckelmann
2017-12-06 18:24             ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5212497.opIP8sI45N@bentobox \
    --to=sven.eckelmann@openmesh.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jiri@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).