From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next 2/3] net/mlx4_en: Notify user when TX ring in error state Date: Mon, 19 Aug 2013 22:49:50 +0400 Message-ID: <521268CE.7040508@cogentembedded.com> References: <1376894542-27854-1-git-send-email-amirv@mellanox.com> <1376894542-27854-3-git-send-email-amirv@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , netdev@vger.kernel.org To: Amir Vadai Return-path: Received: from mail-lb0-f181.google.com ([209.85.217.181]:63980 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098Ab3HSStt (ORCPT ); Mon, 19 Aug 2013 14:49:49 -0400 Received: by mail-lb0-f181.google.com with SMTP id o10so3242851lbi.26 for ; Mon, 19 Aug 2013 11:49:48 -0700 (PDT) In-Reply-To: <1376894542-27854-3-git-send-email-amirv@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 08/19/2013 10:42 AM, Amir Vadai wrote: > When hardware gets into error state, must notify user about it. > When QP in error state no traffic will be tx'ed from the attached > tx_ring. > Driver should know how to recover from this unexpected state. I will send later > on the recovery flow, but having the print shouldn't be delayed. > Signed-off-by: Amir Vadai > --- > drivers/net/ethernet/mellanox/mlx4/en_tx.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c > index 6dcca98..157bcd1 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c > @@ -362,6 +362,14 @@ static void mlx4_en_process_tx_cq(struct net_device *dev, struct mlx4_en_cq *cq) > */ > rmb(); > > + if (unlikely((cqe->owner_sr_opcode & MLX4_CQE_OPCODE_MASK) == > + MLX4_CQE_OPCODE_ERROR)) { > + struct mlx4_err_cqe *cqe_err = (struct mlx4_err_cqe *)cqe; Empty line wouldn't hurt here, after declaration. > + en_err(priv, "CQE error - vendor syndrom: 0x%x syndrom: 0x%x\n", s/syndrom/syndrome/ as below? > + cqe_err->vendor_err_syndrome, > + cqe_err->syndrome); > + } > + WBR, Sergei