From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Chen Gang <gang.chen@asianux.com>
Cc: wg@grandegger.com, anilkumar@ti.com,
Tony Lindgren <tony@atomide.com>,
jg1.han@samsung.com, David Miller <davem@davemloft.net>,
linux-can@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH next] drivers: net: can: c_can: add type cast from 'unsigned int' to 'int'
Date: Wed, 21 Aug 2013 11:45:02 +0200 [thread overview]
Message-ID: <52148C1E.3020709@pengutronix.de> (raw)
In-Reply-To: <521483CD.8050907@asianux.com>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On 08/21/2013 11:09 AM, Chen Gang wrote:
> 'priv->instance' may less than zero, so need a type cast, the related
> warnings (allmodconfig, "EXTRA_CFLAGS=-W"):
>
> drivers/net/can/c_can/c_can_platform.c:198:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Tnx, I've tweaked the commit message a bit, will send a v2.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2013-08-21 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 9:09 [PATCH next] drivers: net: can: c_can: add type cast from 'unsigned int' to 'int' Chen Gang
2013-08-21 9:45 ` Marc Kleine-Budde [this message]
2013-08-21 10:04 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52148C1E.3020709@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=anilkumar@ti.com \
--cc=davem@davemloft.net \
--cc=gang.chen@asianux.com \
--cc=jg1.han@samsung.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox