From: Daniel Borkmann <dborkman@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net: tcp_probe: add IPv6 support
Date: Thu, 22 Aug 2013 23:20:23 +0200 [thread overview]
Message-ID: <52168097.7050200@redhat.com> (raw)
In-Reply-To: <20130822.134309.2073296501906078763.davem@davemloft.net>
On 08/22/2013 10:43 PM, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Wed, 21 Aug 2013 19:48:00 +0200
>
>> + union {
>> + struct sockaddr raw;
>> + struct sockaddr_in v4;
>> + struct sockaddr_in6 v6;
>> + } src, dst;
>
> This bloats up the tcp_log structure unnecessarily. You have
> absolutely no use for the port member, for example.
>
> I know you want to use this so that you can be lazy and only
> use the single printf format specifier. Here, keeping the
> tcp_log compact is more important.
Well, the port is being filled out *and* used in both IPv4 and IPv6
cases. That is why %pISpc is being used, hence IP + port that is being
printed. The port was of course also printed to the log before in
IPv4 only case, so nothing would change there.
next prev parent reply other threads:[~2013-08-22 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 17:47 [PATCH net-next 0/3] Various tcp_probe module improvements Daniel Borkmann
2013-08-21 17:47 ` [PATCH net-next 1/3] net: tcp_probe: also include rcv_wnd next to snd_wnd Daniel Borkmann
2013-08-21 17:47 ` [PATCH net-next 2/3] net: tcp_probe: kprobes: adapt jtcp_rcv_established signature Daniel Borkmann
2013-08-21 17:48 ` [PATCH net-next 3/3] net: tcp_probe: add IPv6 support Daniel Borkmann
2013-08-22 20:43 ` David Miller
2013-08-22 21:20 ` Daniel Borkmann [this message]
2013-08-22 21:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52168097.7050200@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).