From: Doug Ledford <dledford@redhat.com>
To: netdev@vger.kernel.org
Cc: Doug Ledford <dledford@redhat.com>,
Santosh Rastapur <santosh@chelsio.com>,
Jay Fenlason <fenlason@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Divy Le ray <divy@chelsio.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>
Subject: [PATCH] net/cxgb3: fix revert error
Date: Thu, 22 Aug 2013 18:27:59 -0400 [thread overview]
Message-ID: <5216906F.8000000@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]
728e2cc Revert "cxgb3: Check and handle the dma mapping errors"
reverted f83331b cxgb3: Check and handle the dma mapping errors,
however, in between those two there was also
be8b678 cxgb3: Correct comparisons and calculations using skb->tail and
skb-transport_header and
15dd16c cxgb3: Correct comparisons and calculations using skb->tail and
skb-transport_header
The author of the revert did not fix up the conflicts in such as way as
to preserve the other two commits, so they were reverted too. As they
correct math issues under certain conditions, they should be retained.
This puts them back in place.
Signed-off-by: Doug Ledford <dledford@redhat.com>
---
drivers/net/ethernet/chelsio/cxgb3/sge.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb3/sge.c
b/drivers/net/ethernet/chelsio/cxgb3/sge.c
index 9c89dc8..632b318 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/sge.c
@@ -1599,7 +1599,8 @@ static void write_ofld_wr(struct adapter *adap,
struct sk_buff *skb,
flits = skb_transport_offset(skb) / 8;
sgp = ndesc == 1 ? (struct sg_ent *)&d->flit[flits] : sgl;
sgl_flits = make_sgl(skb, sgp, skb_transport_header(skb),
- skb->tail - skb->transport_header,
+ skb_tail_pointer(skb) -
+ skb_transport_header(skb),
adap->pdev);
if (need_skb_unmap()) {
setup_deferred_unmapping(skb, adap->pdev, sgp, sgl_flits);
--
1.8.1.4
[-- Attachment #2: Attached Message Part --]
[-- Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2013-08-22 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 22:27 Doug Ledford [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-27 6:11 [PATCH] net/cxgb3: fix revert error Doug Ledford
2013-08-27 6:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5216906F.8000000@redhat.com \
--to=dledford@redhat.com \
--cc=aik@ozlabs.ru \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=fenlason@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=santosh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).