From: Sekhar Nori <nsekhar@ti.com>
To: Daniel Mack <zonque@gmail.com>
Cc: mugunthanvnm@ti.com, sergei.shtylyov@cogentembedded.com,
d-gerlach@ti.com, netdev@vger.kernel.org, vaibhav.bedia@ti.com,
devicetree@vger.kernel.org, ujhelyi.m@gmail.com,
linux-omap@vger.kernel.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] ARM: dts: am33xx: adopt to cpsw changes
Date: Fri, 23 Aug 2013 15:10:34 +0530 [thread overview]
Message-ID: <52172E12.2000908@ti.com> (raw)
In-Reply-To: <52172CB0.9030204@gmail.com>
On Friday 23 August 2013 03:04 PM, Daniel Mack wrote:
> On 23.08.2013 11:28, Sekhar Nori wrote:
>> On Friday 23 August 2013 02:13 PM, Daniel Mack wrote:
>>> This third memory region just denotes one single register in the CONTROL
>>> module block. The driver uses that in order to set the correct physical
>>> ethernet interface modes.
>>>
>>> Also update the compatible string to make use of the am335x specific
>>> features of the cpsw driver.
>>>
>>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>>> ---
>>> arch/arm/boot/dts/am33xx.dtsi | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>>> index a785b95..1a1e9dd 100644
>>> --- a/arch/arm/boot/dts/am33xx.dtsi
>>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>>> @@ -446,7 +446,7 @@
>>> };
>>>
>>> mac: ethernet@4a100000 {
>>> - compatible = "ti,cpsw";
>>> + compatible = "ti,am3352-cpsw";
>>
>> Please keep this as
>>
>> compatible = "ti,am3352-cpsw", "ti,cpsw";
>>
>> so users can upgrade the DTB or kernel independently. Apart from this
>> the series looks good to me.
>
> Ok, thanks. Given that this last patch will be merged through another
> tree, can I just resend it separately, while David takes the rest as it is?
Ideally you could, but there are some bugs in the way compatible string
in handled and due to this I suspect you need to reorder
cpsw_of_mtable[] to match correctly. Not sure if the bug has been fixed
in recent -rcs. Please check if modifying just this patch works and then
go ahead and post.
Please Cc Benoit Cousson <bcousson@baylibre.com> on your next submission
as he is the one who picks up DT patches for OMAP.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-08-23 9:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 8:43 [PATCH v2 0/5] cpsw: support for control module register Daniel Mack
2013-08-23 8:43 ` [PATCH v2 1/5] net: ethernet: cpsw: switch to devres allocations Daniel Mack
2013-08-23 8:43 ` [PATCH v2 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Daniel Mack
2013-08-23 14:03 ` Sergei Shtylyov
2013-08-23 14:05 ` Daniel Mack
2013-08-23 8:43 ` [PATCH v2 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string Daniel Mack
2013-08-23 8:43 ` [PATCH v2 4/5] net: ethernet: cpsw: add support for hardware interface mode config Daniel Mack
2013-08-23 16:38 ` Mugunthan V N
2013-08-23 8:43 ` [PATCH v2 5/5] ARM: dts: am33xx: adopt to cpsw changes Daniel Mack
2013-08-23 9:28 ` Sekhar Nori
2013-08-23 9:34 ` Daniel Mack
2013-08-23 9:40 ` Sekhar Nori [this message]
2013-08-23 12:08 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52172E12.2000908@ti.com \
--to=nsekhar@ti.com \
--cc=d-gerlach@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ujhelyi.m@gmail.com \
--cc=vaibhav.bedia@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).