From: Stefan Assmann <sassmann@kpanic.de>
To: David Miller <davem@davemloft.net>
Cc: jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
netdev@vger.kernel.org, gospo@redhat.com,
shannon.nelson@intel.com, peter.p.waskiewicz.jr@intel.com,
e1000-devel@lists.sourceforge.net
Subject: Re: [net-next v2 2/8] i40e: transmit, receive, and napi
Date: Sat, 24 Aug 2013 11:31:24 +0200 [thread overview]
Message-ID: <52187D6C.1080202@kpanic.de> (raw)
In-Reply-To: <20130823.110415.1251655571740007987.davem@davemloft.net>
On 23.08.2013 20:04, David Miller wrote:
> From: Stefan Assmann <sassmann@kpanic.de>
> Date: Fri, 23 Aug 2013 14:42:07 +0200
>
>> On 23.08.2013 04:15, Jeff Kirsher wrote:
>>> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>>>
>>> This patch contains the transmit, receive, and napi routines, as well
>>> as ancillary routines.
>>>
>>> This file is code that is (will be) shared between the VF and PF
>>> drivers.
>>
>> Just some small nitpicks.
>>
>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
>>> new file mode 100644
>>> index 0000000..ceafef0
>>> --- /dev/null
>>> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
>>
>> [...]
>>
>>> +static void i40e_receive_skb(struct i40e_ring *rx_ring,
>>> + struct sk_buff *skb, u16 vlan_tag)
>>> +{
>>> + struct i40e_vsi *vsi = rx_ring->vsi;
>>> + struct i40e_q_vector *q_vector = rx_ring->q_vector;
>>> + u64 flags = vsi->back->flags;
>>> +
>>> + if (vlan_tag & VLAN_VID_MASK)
>>> + __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan_tag);
>>
>> Suggesting __constant_htons instead of htons here.
>
> We don't suggest that anymore, because it's completely unnecessary
> with the way the macros are implemented.
>
Okay, good to know. I see it being used frequently in igb, ixgbe so my
assumption was it's the way to go.
Stefan
next prev parent reply other threads:[~2013-08-24 9:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 2:15 [net-next v2 0/8][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-08-23 2:15 ` [net-next v2 1/8] i40e: main driver core Jeff Kirsher
2013-08-23 7:28 ` David Miller
2013-08-23 17:00 ` Nelson, Shannon
2013-08-27 20:34 ` Nelson, Shannon
2013-08-28 1:31 ` David Miller
2013-08-23 11:37 ` Stefan Assmann
2013-08-23 18:35 ` Nelson, Shannon
2013-08-23 2:15 ` [net-next v2 2/8] i40e: transmit, receive, and napi Jeff Kirsher
2013-08-23 12:42 ` Stefan Assmann
2013-08-23 18:04 ` David Miller
2013-08-24 9:31 ` Stefan Assmann [this message]
2013-08-23 18:37 ` Nelson, Shannon
2013-08-23 2:15 ` [net-next v2 3/8] i40e: driver ethtool core Jeff Kirsher
2013-08-23 17:08 ` Stefan Assmann
2013-08-23 18:40 ` Nelson, Shannon
2013-08-23 2:15 ` [net-next v2 4/8] i40e: driver core headers Jeff Kirsher
2013-08-23 2:15 ` [net-next v2 5/8] i40e: implement virtual device interface Jeff Kirsher
2013-08-23 2:15 ` [net-next v2 6/8] i40e: init code and hardware support Jeff Kirsher
2013-08-23 2:15 ` [net-next v2 7/8] i40e: sysfs and debugfs interfaces Jeff Kirsher
2013-08-23 2:15 ` [net-next v2 8/8] i40e: include i40e in kernel proper Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52187D6C.1080202@kpanic.de \
--to=sassmann@kpanic.de \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).