Re: [RFC] b44: use phylib

[Hauke Mehrtens <hauke@hauke-m.de>]

On 08/24/2013 01:10 AM, Joe Perches wrote:
> On Sat, 2013-08-24 at 00:56 +0200, Hauke Mehrtens wrote:
>> This splits the driver into the mac and a phy driver. On routers where
>> this driver is used we have a switch which implements a phy and can be
>> controlled by a phy driver.
> 
> trivial comments only...

I will extend this.

>> diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
> []
>> +static void b44_adjust_link(struct net_device *dev)
>> +{
>> +	struct b44 *bp = netdev_priv(dev);
>> +	struct phy_device *phydev = bp->phydev;
>> +	int status_changed = 0;
> 
> bool?

Thanks, I will change this.

>> +static int b44_mii_probe(struct net_device *dev)
>> +{
> []
>> +	if (IS_ERR(phydev)) {
>> +		netdev_err(dev, "could not attach PHY: %s", phy_id);
> 
> missing newline?

Fixed.