From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Subject: Re: [PATCH] net/cadence/macb: fix kernel Oops if no PHY were discovered during probe Date: Mon, 26 Aug 2013 17:09:42 +0800 Message-ID: <521B1B56.8060903@atmel.com> References: <1377372065-8938-1-git-send-email-b.brezillon@overkiz.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: Nicolas Ferre , , , To: Boris BREZILLON Return-path: In-Reply-To: <1377372065-8938-1-git-send-email-b.brezillon@overkiz.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Boris, On 08/25/2013 03:21 AM, Boris BREZILLON wrote: > Test the presence of a PHY device before printing attached PHY > informations. > > Signed-off-by: Boris BREZILLON > --- > drivers/net/ethernet/cadence/macb.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index e866608..fd3b67f 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -1868,8 +1868,10 @@ static int __init macb_probe(struct platform_device *pdev) > dev->irq, dev->dev_addr); > > phydev = bp->phy_dev; > - netdev_info(dev, "attached PHY driver [%s] (mii_bus:phy_addr=%s, irq=%d)\n", > - phydev->drv->name, dev_name(&phydev->dev), phydev->irq); > + if (phydev) > + netdev_info(dev, "attached PHY driver [%s] (mii_bus:phy_addr=%s, irq=%d)\n", > + phydev->drv->name, dev_name(&phydev->dev), > + phydev->irq); Actually no need this check, if PHY is attached failed, the macb driver probe will fail, then it won't show this message. > return 0; > > Best Regards, Bo Shen