* [PATCH] sh_eth: no need to call ether_setup()
@ 2013-08-29 20:24 Sergei Shtylyov
2013-08-29 20:29 ` Sergei Shtylyov
2013-08-30 3:49 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-08-29 20:24 UTC (permalink / raw)
To: netdev; +Cc: nobuhiro.iwamatsu.yj, linux-sh
There's no need to call ether_setup() in the driver since prior alloc_etherdev()
call already arranges for it.
Suggested-by: Denis Kirjanov <kda@linux-powerpc.org>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
drivers/net/ethernet/renesas/sh_eth.c | 3 ---
1 file changed, 3 deletions(-)
Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net-next/drivers/net/ethernet/renesas/sh_eth.c
@@ -2639,9 +2639,6 @@ static int sh_eth_drv_probe(struct platf
SET_NETDEV_DEV(ndev, &pdev->dev);
- /* Fill in the fields of the device structure with ethernet values. */
- ether_setup(ndev);
-
mdp = netdev_priv(ndev);
mdp->num_tx_ring = TX_RING_SIZE;
mdp->num_rx_ring = RX_RING_SIZE;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sh_eth: no need to call ether_setup()
2013-08-29 20:24 [PATCH] sh_eth: no need to call ether_setup() Sergei Shtylyov
@ 2013-08-29 20:29 ` Sergei Shtylyov
2013-08-30 3:49 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-08-29 20:29 UTC (permalink / raw)
To: netdev; +Cc: nobuhiro.iwamatsu.yj, linux-sh
Hello.
On 08/30/2013 12:24 AM, Sergei Shtylyov wrote:
> There's no need to call ether_setup() in the driver since prior alloc_etherdev()
> call already arranges for it.
> Suggested-by: Denis Kirjanov <kda@linux-powerpc.org>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> ---
Sorry, forgot to mention the patch is against the 'net-next.git' repo. :-/
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sh_eth: no need to call ether_setup()
2013-08-29 20:24 [PATCH] sh_eth: no need to call ether_setup() Sergei Shtylyov
2013-08-29 20:29 ` Sergei Shtylyov
@ 2013-08-30 3:49 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2013-08-30 3:49 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, nobuhiro.iwamatsu.yj, linux-sh
On Fri, Aug 30, 2013 at 12:24:47AM +0400, Sergei Shtylyov wrote:
> There's no need to call ether_setup() in the driver since prior alloc_etherdev()
> call already arranges for it.
>
> Suggested-by: Denis Kirjanov <kda@linux-powerpc.org>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
> ===================================================================
> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
> @@ -2639,9 +2639,6 @@ static int sh_eth_drv_probe(struct platf
>
> SET_NETDEV_DEV(ndev, &pdev->dev);
>
> - /* Fill in the fields of the device structure with ethernet values. */
> - ether_setup(ndev);
> -
> mdp = netdev_priv(ndev);
> mdp->num_tx_ring = TX_RING_SIZE;
> mdp->num_rx_ring = RX_RING_SIZE;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-30 3:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-29 20:24 [PATCH] sh_eth: no need to call ether_setup() Sergei Shtylyov
2013-08-29 20:29 ` Sergei Shtylyov
2013-08-30 3:49 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).