From: "Per Dalén" <per.dalen@appeartv.com>
To: netdev@vger.kernel.org
Subject: Re: BQL support in gianfar causes network hiccup
Date: Mon, 02 Sep 2013 15:21:15 +0200 [thread overview]
Message-ID: <522490CB.60008@appeartv.com> (raw)
> On Mo, 2013-04-29 at 15:20 +0200, Tino Keitel wrote:
> > On Mo, 2013-04-29 at 15:14 +0200, Claudiu Manoil wrote:
> >
> > > The proposed fix (passes this test):
> > > http://patchwork.ozlabs.org/patch/240365/
> > >
> > > Does it work for you?
Hi,
This patch do not work for me. I have the same problems that Tino on my
card. My card is a Freescale P2020 and I use "iperf -c 10.10.51.36 -n
100M -P 50" to trigger the error.
The network interface is set to 100M half duplex.
I have tested this using 3.4.35 and 3.4.60 kernel.
NETDEV WATCHDOG: eth0 (fsl-gianfar): transmit queue 0 timed out
------------[ cut here ]------------
WARNING: at net/sched/sch_generic.c:256
Modules linked in:
NIP: c039bb94 LR: c039bb94 CTR: c02ee500
REGS: dffe7e60 TRAP: 0700 Not tainted (3.4.60+)
MSR: 00029000 <CE,EE,ME> CR: 40000084 XER: 20000000
TASK = df843200[0] 'swapper/1' THREAD: df864000 CPU: 1
GPR00: c039bb94 dffe7f10 df843200 00000046 00021000 ffffffff c02eecf0
00029000
GPR08: 00000001 00008000 00463000 00003fff 80000028 00000000 00000000
00000004
GPR16: 00000001 df858e14 c051f1f4 00000001 df858c14 df858a14 df858814
ffffffff
GPR24: 00000001 df813234 00000004 df8f9a00 c05e0000 c05e0000 df813000
00000000
NIP [c039bb94] dev_watchdog+0x2d4/0x2e4
LR [c039bb94] dev_watchdog+0x2d4/0x2e4
Call Trace:
[dffe7f10] [c039bb94] dev_watchdog+0x2d4/0x2e4 (unreliable)
[dffe7f40] [c003e944] run_timer_softirq+0x11c/0x20c
[dffe7fa0] [c00377dc] __do_softirq+0xe4/0x16c
[dffe7ff0] [c000c408] call_do_softirq+0x14/0x24
[df865e80] [c00043c4] do_softirq+0xb4/0xe4
[df865ea0] [c0037b4c] irq_exit+0xb0/0xcc
[df865eb0] [c0008958] timer_interrupt+0x188/0x1a4
[df865ee0] [c000db68] ret_from_except+0x0/0x18
--- Exception: 901 at cpu_idle+0x90/0xf4
LR = cpu_idle+0x90/0xf4
[df865fa0] [c0007b30] cpu_idle+0x5c/0xf4 (unreliable)
[df865fc0] [c049d68c] start_secondary+0x2b0/0x2b4
[df865ff0] [c0001cf8] __secondary_start+0x30/0x84
Instruction dump:
4e800421 80fe0244 4bffff40 7fc3f378 4bfeab6d 7fc4f378 7c651b78 3c60c055
7fe6fb78 38633108 4cc63182 480fc889 <0fe00000> 39200001 993cea1a 4bffffb4
---[ end trace 4be011773b23dae3 ]---
When I revert "gianfar: Add support for byte queue limits.", commit
d8a0f1b0af67679bba886784de10d8c21acc4e0e, the network test work fine
without any "hiccup".
If the network interface is set to 1000M full duplex there's also no
"hiccup".
>
> Hi,
>
> I tested the patch over the weekend and it looks fine. I then re-checked
> without the patch and got the bug immediately. So the patch seems to
> work fine.
>
Thanks,
Per Dalén
next reply other threads:[~2013-09-02 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 13:21 Per Dalén [this message]
2013-09-02 13:53 ` BQL support in gianfar causes network hiccup Claudiu Manoil
2013-09-02 14:37 ` Per Dalén
2013-09-02 15:35 ` Claudiu Manoil
2013-09-02 16:50 ` Per Dalén
2013-09-03 7:06 ` Claudiu Manoil
2013-09-03 7:55 ` Per Dalén
2013-09-03 15:42 ` Eric Dumazet
2013-09-03 16:09 ` Claudiu Manoil
2013-09-03 19:33 ` Per Dalén
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522490CB.60008@appeartv.com \
--to=per.dalen@appeartv.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).