From: David Daney <ddaney.cavm@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>, David Miller <davem@davemloft.net>
Cc: David Daney <david.daney@cavium.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] bcm87xx: Add MODULE_DEVICE_TABLE
Date: Tue, 03 Sep 2013 10:32:02 -0700 [thread overview]
Message-ID: <52261D12.5000009@gmail.com> (raw)
In-Reply-To: <1378071184.25743.52.camel@deadeye.wl.decadent.org.uk>
On 09/01/2013 02:33 PM, Ben Hutchings wrote:
> bcm87xx currently isn't auto-loaded if built as a module.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> Compile-tested only.
Then how do you know that it does anything sensible?
Other than that, it seems plausible.
David Daney
>
> Ben.
>
> drivers/net/phy/bcm87xx.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
> index 7997895..f5b44ff 100644
> --- a/drivers/net/phy/bcm87xx.c
> +++ b/drivers/net/phy/bcm87xx.c
> @@ -230,4 +230,11 @@ static void __exit bcm87xx_exit(void)
> }
> module_exit(bcm87xx_exit);
>
> +static struct mdio_device_id __maybe_unused bcm87xx_tbl[] = {
> + { PHY_ID_BCM8706, 0xffffffff },
> + { PHY_ID_BCM8727, 0xffffffff },
> + { }
> +};
> +
> MODULE_LICENSE("GPL");
> +MODULE_DEVICE_TABLE(mdio, bcm87xx_tbl);
>
next prev parent reply other threads:[~2013-09-03 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 21:33 [PATCH net-next] bcm87xx: Add MODULE_DEVICE_TABLE Ben Hutchings
2013-09-03 17:32 ` David Daney [this message]
2013-09-03 18:53 ` Ben Hutchings
2013-09-03 19:13 ` David Daney
2013-09-03 19:28 ` David Daney
2013-09-03 20:53 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52261D12.5000009@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).