From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH] can: pcan_usb_core: fix memory leak on failure paths in peak_usb_start() Date: Fri, 06 Sep 2013 11:03:32 +0200 Message-ID: <52299A64.2070102@pengutronix.de> References: <1378331169-26285-1-git-send-email-khoroshilov@ispras.ru> <52285006.3080303@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6FpgdfratEXkxcwuFFvJ9XNSWqAnvfIo2" Cc: Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org, "s.grosjean@peak-system.com" To: Alexey Khoroshilov Return-path: In-Reply-To: <52285006.3080303@pengutronix.de> Sender: linux-can-owner@vger.kernel.org List-Id: netdev.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6FpgdfratEXkxcwuFFvJ9XNSWqAnvfIo2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/05/2013 11:33 AM, Marc Kleine-Budde wrote: > Added Stephane to Cc. >=20 > On 09/04/2013 11:46 PM, Alexey Khoroshilov wrote: >> Tx and rx urbs are not deallocated if something goes wrong in peak_usb= _start(). >> The patch fixes error handling to deallocate all the resources. >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signed-off-by: Alexey Khoroshilov >=20 > Stephane, can you have a look at the patch and give your Acked-by. >=20 > Looks good to me. Applied with Stephane's Acked-by to can/fixes-for-3.12. Tnx, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --6FpgdfratEXkxcwuFFvJ9XNSWqAnvfIo2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlIpmmQACgkQjTAFq1RaXHO3tgCeIBu44NqG47DMuQNm6Ln4bQJq Pn4AnRxd0iV9KNTmAuRBRgVl24qt4h0y =pDo0 -----END PGP SIGNATURE----- --6FpgdfratEXkxcwuFFvJ9XNSWqAnvfIo2--