From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Jonathan Davies <Jonathan.Davies@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>, <netdev@vger.kernel.org>,
<xen-devel@lists.xenproject.org>
Subject: Re: TSQ accounting skb->truesize degrades throughput for large packets
Date: Mon, 9 Sep 2013 22:41:20 +0100 [thread overview]
Message-ID: <522E4080.2050802@citrix.com> (raw)
In-Reply-To: <1378574494.26319.14.camel@edumazet-glaptop>
On 07/09/13 18:21, Eric Dumazet wrote:
> On Fri, 2013-09-06 at 10:00 -0700, Eric Dumazet wrote:
>> On Fri, 2013-09-06 at 17:36 +0100, Zoltan Kiss wrote:
>>
>>> So I guess it would be good to revisit the default value of this
>>> setting.
>>
>> If ixgbe requires 3 TSO packets in TX ring to get line rate, you also
>> can tweak dev->gso_max_size from 65535 to 64000.
>
> Another idea would be to no longer use tcp_limit_output_bytes but
>
> max(sk_pacing_rate / 1000, 2*MSS)
I've tried this on a freshly updated upstream, and it solved my problem
on ixgbe:
- if (atomic_read(&sk->sk_wmem_alloc) >=
sysctl_tcp_limit_output_bytes) {
+ if (atomic_read(&sk->sk_wmem_alloc) >=
max(sk->sk_pacing_rate / 1000, 2 * mss_now) ){
Now I can get proper line rate. Btw. I've tried to decrease
dev->gso_max_size to 60K or 32K, both was ineffective.
Regards,
Zoli
next prev parent reply other threads:[~2013-09-09 21:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 10:16 TSQ accounting skb->truesize degrades throughput for large packets Wei Liu
2013-09-06 12:57 ` Eric Dumazet
2013-09-06 13:12 ` Wei Liu
2013-09-06 16:36 ` Zoltan Kiss
2013-09-06 16:56 ` Eric Dumazet
2013-09-09 9:27 ` Jason Wang
2013-09-09 13:47 ` Eric Dumazet
2013-09-10 7:45 ` Jason Wang
2013-09-10 12:35 ` Eric Dumazet
2013-09-06 17:00 ` Eric Dumazet
2013-09-07 17:21 ` Eric Dumazet
2013-09-09 21:41 ` Zoltan Kiss [this message]
2013-09-09 21:56 ` Eric Dumazet
[not found] ` <loom.20130921T045654-573@post.gmane.org>
[not found] ` <20130921150327.GA9078@zion.uk.xensource.com>
2013-09-22 2:36 ` [Xen-devel] " Cong Wang
2013-09-22 14:58 ` Eric Dumazet
2013-09-27 10:28 ` [PATCH] tcp: TSQ can use a dynamic limit Eric Dumazet
2013-09-27 15:08 ` Neal Cardwell
2013-09-29 15:41 ` Cong Wang
2013-10-01 3:52 ` David Miller
2013-09-09 5:28 ` TSQ accounting skb->truesize degrades throughput for large packets Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522E4080.2050802@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=Jonathan.Davies@eu.citrix.com \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).