From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Francois Romieu <romieu@fr.zoreil.com>,
Igor Gnatenko <i.gnatenko.brain@gmail.com>,
stephen@networkplumber.org
Subject: Re: [PATCH] skge: fix invalid value passed to pci_unmap_sigle
Date: Sun, 22 Sep 2013 02:12:52 +0400 [thread overview]
Message-ID: <523E19E4.20005@cogentembedded.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1309201352010.1763@file01.intranet.prod.int.rdu2.redhat.com>
Hello.
On 09/20/2013 09:53 PM, Mikulas Patocka wrote:
> In my patch c194992cbe71c20bb3623a566af8d11b0bfaa721 I didn't fix the skge
Please also specify that commit's summary in parens.
> bug correctly. The value of the new mapping (not old) was passed to
> pci_unmap_single.
> If we enable CONFIG_DMA_API_DEBUG, it results in this warning:
> WARNING: CPU: 0 PID: 0 at lib/dma-debug.c:986 check_sync+0x4c4/0x580()
> skge 0000:02:07.0: DMA-API: device driver tries to sync DMA memory it has
> not allocated [device address=0x000000023a0096c0] [size=1536 bytes]
> This patch makes the skge driver pass the correct value to
> pci_unmap_single and fixes the warning. It copies the old descriptor to
> on-stack variable "ee" and unmaps it if mapping of the new descriptor
> succeeded.
> This patch should be backported to 3.11-stable.
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> Reported-by: Francois Romieu <romieu@fr.zoreil.com>
> Tested-by: Mikulas Patocka <mpatocka@redhat.com>
WBR, Sergei
next prev parent reply other threads:[~2013-09-21 22:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 17:53 [PATCH] skge: fix invalid value passed to pci_unmap_sigle Mikulas Patocka
2013-09-21 22:12 ` Sergei Shtylyov [this message]
2013-09-24 14:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523E19E4.20005@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=i.gnatenko.brain@gmail.com \
--cc=mpatocka@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).