From: Vlad Yasevich <vyasevich@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH 12/12] sctp: Remove extern from function prototypes
Date: Mon, 23 Sep 2013 15:11:36 -0400 [thread overview]
Message-ID: <52409268.1050602@gmail.com> (raw)
In-Reply-To: <6738b115d30d40f33c688863f5421d84d2aa706c.1379961014.git.joe@perches.com>
On 09/23/2013 02:37 PM, Joe Perches wrote:
> There are a mix of function prototypes with and without extern
> in the kernel sources. Standardize on not using extern for
> function prototypes.
>
> Function prototypes don't need to be written with extern.
> extern is assumed by the compiler. Its use is as unnecessary as
> using auto to declare automatic/local variables in a block.
>
> Signed-off-by: Joe Perches <joe@perches.com>
looks simple enough.
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
-vlad
> ---
> include/net/sctp/sctp.h | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h
> index 3794c5a..c5fe806 100644
> --- a/include/net/sctp/sctp.h
> +++ b/include/net/sctp/sctp.h
> @@ -90,12 +90,11 @@
> /*
> * sctp/protocol.c
> */
> -extern int sctp_copy_local_addr_list(struct net *, struct sctp_bind_addr *,
> - sctp_scope_t, gfp_t gfp,
> - int flags);
> -extern struct sctp_pf *sctp_get_pf_specific(sa_family_t family);
> -extern int sctp_register_pf(struct sctp_pf *, sa_family_t);
> -extern void sctp_addr_wq_mgmt(struct net *, struct sctp_sockaddr_entry *, int);
> +int sctp_copy_local_addr_list(struct net *, struct sctp_bind_addr *,
> + sctp_scope_t, gfp_t gfp, int flags);
> +struct sctp_pf *sctp_get_pf_specific(sa_family_t family);
> +int sctp_register_pf(struct sctp_pf *, sa_family_t);
> +void sctp_addr_wq_mgmt(struct net *, struct sctp_sockaddr_entry *, int);
>
> /*
> * sctp/socket.c
> @@ -110,7 +109,7 @@ void sctp_sock_rfree(struct sk_buff *skb);
> void sctp_copy_sock(struct sock *newsk, struct sock *sk,
> struct sctp_association *asoc);
> extern struct percpu_counter sctp_sockets_allocated;
> -extern int sctp_asconf_mgmt(struct sctp_sock *, struct sctp_sockaddr_entry *);
> +int sctp_asconf_mgmt(struct sctp_sock *, struct sctp_sockaddr_entry *);
>
> /*
> * sctp/primitive.c
>
next prev parent reply other threads:[~2013-09-23 19:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 18:33 [PATCH 01/12] tcp.h: Remove extern from function prototypes Joe Perches
2013-09-23 18:33 ` [PATCH 02/12] udp.h: " Joe Perches
2013-09-23 18:33 ` [PATCH 03/12] udplite.h: " Joe Perches
2013-09-23 18:33 ` [PATCH 04/12] wext.h: " Joe Perches
2013-09-23 18:33 ` [PATCH 05/12] wimax.h: " Joe Perches
2013-09-23 18:33 ` [PATCH 06/12] x25.h: " Joe Perches
2013-09-23 18:33 ` [PATCH 07/12] xfrm.h: " Joe Perches
2013-09-23 18:37 ` [PATCH 08/12] bluetooth: " Joe Perches
2013-09-24 4:24 ` Marcel Holtmann
2013-09-23 18:37 ` [PATCH 09/12] caif_hsi.h: " Joe Perches
2013-09-23 18:37 ` [PATCH 10/12] irda: " Joe Perches
2013-09-23 18:37 ` [PATCH 11/12] netfilter: " Joe Perches
2013-09-28 19:17 ` Jan Engelhardt
2013-09-23 18:37 ` [PATCH 12/12] sctp: " Joe Perches
2013-09-23 19:11 ` Vlad Yasevich [this message]
2013-09-23 20:39 ` Neil Horman
2013-09-23 20:30 ` [PATCH 01/12] tcp.h: " David Miller
2013-09-23 20:44 ` Joe Perches
2013-09-23 20:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52409268.1050602@gmail.com \
--to=vyasevich@gmail.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).