netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 01/10] can: Remove extern from function prototypes
@ 2013-09-23 22:11 Joe Perches
  2013-09-23 22:11 ` [PATCH 02/10] 8390: " Joe Perches
                   ` (10 more replies)
  0 siblings, 11 replies; 16+ messages in thread
From: Joe Perches @ 2013-09-23 22:11 UTC (permalink / raw)
  To: netdev
  Cc: David S. Miller, linux-kernel, Wolfgang Grandegger,
	Marc Kleine-Budde, linux-can

There are a mix of function prototypes with and without extern
in the kernel sources.  Standardize on not using extern for
function prototypes.

Function prototypes don't need to be written with extern.
extern is assumed by the compiler.  Its use is as unnecessary as
using auto to declare automatic/local variables in a block.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/can/mscan/mscan.h     |  6 +++---
 drivers/net/can/softing/softing.h | 24 ++++++++++++------------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/net/can/mscan/mscan.h b/drivers/net/can/mscan/mscan.h
index 9c24d60..e98abb9 100644
--- a/drivers/net/can/mscan/mscan.h
+++ b/drivers/net/can/mscan/mscan.h
@@ -297,8 +297,8 @@ struct mscan_priv {
 	struct napi_struct napi;
 };
 
-extern struct net_device *alloc_mscandev(void);
-extern int register_mscandev(struct net_device *dev, int mscan_clksrc);
-extern void unregister_mscandev(struct net_device *dev);
+struct net_device *alloc_mscandev(void);
+int register_mscandev(struct net_device *dev, int mscan_clksrc);
+void unregister_mscandev(struct net_device *dev);
 
 #endif /* __MSCAN_H__ */
diff --git a/drivers/net/can/softing/softing.h b/drivers/net/can/softing/softing.h
index afd7d85..35f0622 100644
--- a/drivers/net/can/softing/softing.h
+++ b/drivers/net/can/softing/softing.h
@@ -71,34 +71,34 @@ struct softing {
 	} id;
 };
 
-extern int softing_default_output(struct net_device *netdev);
+int softing_default_output(struct net_device *netdev);
 
-extern ktime_t softing_raw2ktime(struct softing *card, u32 raw);
+ktime_t softing_raw2ktime(struct softing *card, u32 raw);
 
-extern int softing_chip_poweron(struct softing *card);
+int softing_chip_poweron(struct softing *card);
 
-extern int softing_bootloader_command(struct softing *card, int16_t cmd,
-		const char *msg);
+int softing_bootloader_command(struct softing *card, int16_t cmd,
+			       const char *msg);
 
 /* Load firmware after reset */
-extern int softing_load_fw(const char *file, struct softing *card,
-			__iomem uint8_t *virt, unsigned int size, int offset);
+int softing_load_fw(const char *file, struct softing *card,
+		    __iomem uint8_t *virt, unsigned int size, int offset);
 
 /* Load final application firmware after bootloader */
-extern int softing_load_app_fw(const char *file, struct softing *card);
+int softing_load_app_fw(const char *file, struct softing *card);
 
 /*
  * enable or disable irq
  * only called with fw.lock locked
  */
-extern int softing_enable_irq(struct softing *card, int enable);
+int softing_enable_irq(struct softing *card, int enable);
 
 /* start/stop 1 bus on card */
-extern int softing_startstop(struct net_device *netdev, int up);
+int softing_startstop(struct net_device *netdev, int up);
 
 /* netif_rx() */
-extern int softing_netdev_rx(struct net_device *netdev,
-		const struct can_frame *msg, ktime_t ktime);
+int softing_netdev_rx(struct net_device *netdev, const struct can_frame *msg,
+		      ktime_t ktime);
 
 /* SOFTING DPRAM mappings */
 #define DPRAM_RX		0x0000
-- 
1.8.1.2.459.gbcd45b4.dirty

^ permalink raw reply related	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2013-09-24 18:06 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 22:11 [PATCH 01/10] can: Remove extern from function prototypes Joe Perches
2013-09-23 22:11 ` [PATCH 02/10] 8390: " Joe Perches
2013-09-23 22:11 ` [PATCH 03/10] adi: " Joe Perches
2013-09-23 22:11 ` [PATCH 04/10] amd/7990: " Joe Perches
2013-09-24 16:55   ` Joe Perches
2013-09-24 18:06     ` David Miller
2013-09-23 22:11 ` [PATCH 05/10] atheros: " Joe Perches
2013-09-23 22:11 ` [PATCH 06/10] broadcom: " Joe Perches
2013-09-23 22:11 ` [PATCH 07/10] brocade: " Joe Perches
2013-09-23 22:11 ` [PATCH 08/10] chelsio: " Joe Perches
2013-09-23 22:11 ` [PATCH 09/10] emulex: " Joe Perches
2013-09-23 22:11 ` [PATCH 10/10] gianfar: " Joe Perches
2013-09-24  7:37 ` [PATCH 01/10] can: " Marc Kleine-Budde
2013-09-24 14:02   ` David Miller
2013-09-24 14:22     ` Marc Kleine-Budde
2013-09-24 14:11 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).