From: Marc Kleine-Budde <mkl@pengutronix.de>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, wg@grandegger.com,
linux-can@vger.kernel.org
Subject: Re: [PATCH 01/10] can: Remove extern from function prototypes
Date: Tue, 24 Sep 2013 16:22:55 +0200 [thread overview]
Message-ID: <5241A03F.8070007@pengutronix.de> (raw)
In-Reply-To: <20130924.100209.1219862004963547693.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
On 09/24/2013 04:02 PM, David Miller wrote:
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Date: Tue, 24 Sep 2013 09:37:12 +0200
>
>> On 09/24/2013 12:11 AM, Joe Perches wrote:
>>> There are a mix of function prototypes with and without extern
>>> in the kernel sources. Standardize on not using extern for
>>> function prototypes.
>>>
>>> Function prototypes don't need to be written with extern.
>>> extern is assumed by the compiler. Its use is as unnecessary as
>>> using auto to declare automatic/local variables in a block.
>>>
>>> Signed-off-by: Joe Perches <joe@perches.com>
>>
>> Thx, added to linux-can-next. The patch will be included in the next
>> pull request to David.
>
> Marc, I'm trying to just quickly apply these all into my tree directly.
Fine with me.
Tnx, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2013-09-24 14:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 22:11 [PATCH 01/10] can: Remove extern from function prototypes Joe Perches
2013-09-23 22:11 ` [PATCH 02/10] 8390: " Joe Perches
2013-09-23 22:11 ` [PATCH 03/10] adi: " Joe Perches
2013-09-23 22:11 ` [PATCH 04/10] amd/7990: " Joe Perches
2013-09-24 16:55 ` Joe Perches
2013-09-24 18:06 ` David Miller
2013-09-23 22:11 ` [PATCH 05/10] atheros: " Joe Perches
2013-09-23 22:11 ` [PATCH 06/10] broadcom: " Joe Perches
2013-09-23 22:11 ` [PATCH 07/10] brocade: " Joe Perches
2013-09-23 22:11 ` [PATCH 08/10] chelsio: " Joe Perches
2013-09-23 22:11 ` [PATCH 09/10] emulex: " Joe Perches
2013-09-23 22:11 ` [PATCH 10/10] gianfar: " Joe Perches
2013-09-24 7:37 ` [PATCH 01/10] can: " Marc Kleine-Budde
2013-09-24 14:02 ` David Miller
2013-09-24 14:22 ` Marc Kleine-Budde [this message]
2013-09-24 14:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5241A03F.8070007@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).