From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH] net: flow_dissector: fix thoff for IPPROTO_AH Date: Thu, 26 Sep 2013 18:03:12 +0200 Message-ID: <52445AC0.1070308@redhat.com> References: <1380204582-27144-1-git-send-email-nikolay@redhat.com> <1380204582-27144-2-git-send-email-nikolay@redhat.com> <1380209227.3165.176.camel@edumazet-glaptop> <1380210246.3165.184.camel@edumazet-glaptop> <5244575B.8060309@redhat.com> <1380211524.3165.192.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Daniel Borkmann , netdev@vger.kernel.org, davem@davemloft.net, andy@greyhouse.net, fubar@us.ibm.com, vfalico@redhat.com To: Eric Dumazet Return-path: Received: from mx1.redhat.com ([209.132.183.28]:16119 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447Ab3IZQGs (ORCPT ); Thu, 26 Sep 2013 12:06:48 -0400 In-Reply-To: <1380211524.3165.192.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-ID: On 09/26/2013 06:05 PM, Eric Dumazet wrote: > On Thu, 2013-09-26 at 17:48 +0200, Nikolay Aleksandrov wrote: > >> >> 1 question about my current patchset, can I leave it to get reviewed and if >> applied to post a follow-up for net-next that fixes the issue, or would you >> prefer a v4 that integrates the fix ? > > I think your 1/3 patch only has to pass nhoff as value instead of > reference. > > +__be32 skb_flow_get_ports(const struct sk_buff *skb, int thoff, u8 ip_proto) > +{ > + int poff = proto_ports_offset(ip_proto); > + > + if (poff >= 0) { > + __be32 *ports, _ports; > + > + ports = skb_header_pointer(skb, thoff + poff, > + sizeof(_ports), &_ports); > + if (ports) > + return *ports; > + } > + > + return 0; > +} > > Yeah, exactly but 2/3 will need a change as well because it uses the function. I'll just re-post a v4 with the change in a bit. Thanks