From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ying Xue Subject: Re: [PATCH net-next 1/5] tipc: silence sparse warnings Date: Fri, 27 Sep 2013 17:48:33 +0800 Message-ID: <52455471.8060102@windriver.com> References: <1380014868-2797-1-git-send-email-jon.maloy@ericsson.com> <1380014868-2797-2-git-send-email-jon.maloy@ericsson.com> <20130927.015908.1293107524454870319.davem@davemloft.net> <52453B51.5070702@windriver.com> <52453E8D.2020705@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: jon.maloy@ericsson.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, David Miller To: =?ISO-8859-1?Q?Andreas_Bofj=E4ll?= Return-path: In-Reply-To: <52453E8D.2020705@ericsson.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tipc-discussion-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On 09/27/2013 04:15 PM, Andreas Bofj=E4ll wrote: > On 09/27/2013 10:01 AM, Ying Xue wrote: >> Good point! >> It's better for us to use memcpy_fromiovecend() instead of >> skb_copy_to_linear_data() and its friends. >> >> We will submit another version to correct this error soon. > = > I could be wrong here, but I think you should also remove the entire > cast on line 1210 in link.c: > = > sect_crs =3D msg_sect[curr_sect].iov_base; > = > There should be no reason to cast there since you made sect_crs into > const unchar* __user and msg_sect[].iov_base is void* __user. > = You are right, thank you for your nice reminder! Regards, Ying > /Andreas > = > = ---------------------------------------------------------------------------= --- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most fr= om = the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=3D60133471&iu=3D/4140/ostg.cl= ktrk