From: Jon Maloy <maloy@donjonn.com>
To: Ying Xue <ying.xue@windriver.com>
Cc: "Andreas Bofjäll" <andreas.bofjall@ericsson.com>,
jon.maloy@ericsson.com, netdev@vger.kernel.org,
paul.gortmaker@windriver.com, erik.hugne@ericsson.com,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next 1/5] tipc: silence sparse warnings
Date: Fri, 27 Sep 2013 06:25:07 -0400 [thread overview]
Message-ID: <52455D03.6030308@donjonn.com> (raw)
In-Reply-To: <52455471.8060102@windriver.com>
On 09/27/2013 05:48 AM, Ying Xue wrote:
> On 09/27/2013 04:15 PM, Andreas Bofjäll wrote:
>> On 09/27/2013 10:01 AM, Ying Xue wrote:
>>> Good point!
>>> It's better for us to use memcpy_fromiovecend() instead of
>>> skb_copy_to_linear_data() and its friends.
>>>
>>> We will submit another version to correct this error soon.
Can you fix this asap, so I can re-post it? And, let's continue the thread
in tipc-discussion only until we (incl Paul) are happy with this patch.
///jon
>> I could be wrong here, but I think you should also remove the entire
>> cast on line 1210 in link.c:
>>
>> sect_crs = msg_sect[curr_sect].iov_base;
>>
>> There should be no reason to cast there since you made sect_crs into
>> const unchar* __user and msg_sect[].iov_base is void* __user.
>>
> You are right, thank you for your nice reminder!
>
> Regards,
> Ying
>
>> /Andreas
>>
>>
next prev parent reply other threads:[~2013-09-27 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 9:27 [PATCH net-next 0/5] tipc: some small patches Jon Maloy
2013-09-24 9:27 ` [PATCH net-next 1/5] tipc: silence sparse warnings Jon Maloy
2013-09-27 5:59 ` David Miller
2013-09-27 8:01 ` Ying Xue
2013-09-27 8:15 ` Andreas Bofjäll
2013-09-27 9:48 ` Ying Xue
2013-09-27 10:25 ` Jon Maloy [this message]
2013-09-24 9:27 ` [PATCH net-next 2/5] tipc: make bearer and media naming consistent Jon Maloy
2013-09-24 9:27 ` [PATCH net-next 3/5] tipc: avoid unnecessary lookup for tipc bearer instance Jon Maloy
2013-09-24 9:27 ` [PATCH net-next 4/5] tipc: correct return value of recv_msg routine Jon Maloy
2013-09-24 9:27 ` [PATCH net-next 5/5] tipc: correct return value of link_cmd_set_value routine Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52455D03.6030308@donjonn.com \
--to=maloy@donjonn.com \
--cc=andreas.bofjall@ericsson.com \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).