From: Daniel Mack <zonque@gmail.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, ujhelyi.m@gmail.com,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH 2/2] net: phy: at803x: add suspend/resume callbacks
Date: Fri, 27 Sep 2013 20:49:00 +0200 [thread overview]
Message-ID: <5245D31C.4080104@gmail.com> (raw)
In-Reply-To: <523E877F.4050906@ti.com>
On 22.09.2013 08:00, Mugunthan V N wrote:
> On Saturday 21 September 2013 08:23 PM, Daniel Mack wrote:
>> When WOL is enabled, the chip can't be put into power-down (BMCR_PDOWN)
>> mode, as that will also switch off the MAC, which consequently leads to
>> a link loss.
>>
>> Use BMCR_ISOLATE in that case, which will at least save us some
>> milliamperes in comparison to normal operation mode.
>>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
> Looks good to me
>
> Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Thanks :)
David, can you take these two patches with Mugunthan's Acked-by: or do
you want me to resend them?
Best regards,
Daniel
next prev parent reply other threads:[~2013-09-27 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 14:53 [PATCH 1/2] net: phy: at803x: don't pass function pointers with & Daniel Mack
2013-09-21 14:53 ` [PATCH 2/2] net: phy: at803x: add suspend/resume callbacks Daniel Mack
2013-09-22 6:00 ` Mugunthan V N
2013-09-27 18:49 ` Daniel Mack [this message]
2013-09-27 21:28 ` David Miller
2013-09-22 5:59 ` [PATCH 1/2] net: phy: at803x: don't pass function pointers with & Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5245D31C.4080104@gmail.com \
--to=zonque@gmail.com \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ujhelyi.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).