* [PATCH] Fixed to checkpatch.pl errors to vlan_dev.c
@ 2016-12-05 15:34 Ozgur Karatas
2016-12-05 15:48 ` Stefan Schmidt
0 siblings, 1 reply; 2+ messages in thread
From: Ozgur Karatas @ 2016-12-05 15:34 UTC (permalink / raw)
To: kaber, David Miller; +Cc: netdev, linux-kernel
Hello all,
I will solve a checkpatch errors.
Signed-off-by: Ozgur Karatas <ozgur@member.fsf.org>
---
net/8021q/vlan_dev.c | 2 +-
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index fbfacd5..2edb495 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -738,7 +738,7 @@ static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n
static void vlan_dev_netpoll_cleanup(struct net_device *dev)
{
- struct vlan_dev_priv *vlan= vlan_dev_priv(dev);
+ struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
struct netpoll *netpoll = vlan->netpoll;
if (!netpoll)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Fixed to checkpatch.pl errors to vlan_dev.c
2016-12-05 15:34 [PATCH] Fixed to checkpatch.pl errors to vlan_dev.c Ozgur Karatas
@ 2016-12-05 15:48 ` Stefan Schmidt
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Schmidt @ 2016-12-05 15:48 UTC (permalink / raw)
To: Ozgur Karatas, kaber, David Miller; +Cc: netdev, linux-kernel
Hello.
On 05/12/16 16:34, Ozgur Karatas wrote:
> Hello all,
>
> I will solve a checkpatch errors.
>
> Signed-off-by: Ozgur Karatas <ozgur@member.fsf.org>
The patch itself looks good, but please have a read about having a good
commit message. I would suggest reading Documentation/SubmittingPatches
section 14: The canonical patch format
Especially the parts about the subject line and summary.
>
> ---
> net/8021q/vlan_dev.c | 2 +-
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index fbfacd5..2edb495 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -738,7 +738,7 @@ static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n
>
> static void vlan_dev_netpoll_cleanup(struct net_device *dev)
> {
> - struct vlan_dev_priv *vlan= vlan_dev_priv(dev);
> + struct vlan_dev_priv *vlan = vlan_dev_priv(dev);
> struct netpoll *netpoll = vlan->netpoll;
>
> if (!netpoll)
>
regards
Stefan Schmidt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-05 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-05 15:34 [PATCH] Fixed to checkpatch.pl errors to vlan_dev.c Ozgur Karatas
2016-12-05 15:48 ` Stefan Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).