From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Nguyen Hong Ky <nh-ky@jinso.co.jp>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Ryusuke Sakato <ryusuke.sakato.bx@renesas.com>,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH] net: sh_eth: Fix RX packets errors on R8A7740
Date: Sat, 12 Oct 2013 18:58:40 +0200 [thread overview]
Message-ID: <52597FC0.4090801@cogentembedded.com> (raw)
In-Reply-To: <1381127365-6521-2-git-send-email-nh-ky@jinso.co.jp>
Hello.
On 07-10-2013 8:29, Nguyen Hong Ky wrote:
> This patch will fix RX packets errors when receiving big size
> of data by set bit RNC = 1.
> RNC - Receive Enable Control
> 0: Upon completion of reception of one frame, the E-DMAC writes
> the receive status to the descriptor and clears the RR bit in
> EDRRR to 0.
> 1: Upon completion of reception of one frame, the E-DMAC writes
> (writes back) the receive status to the descriptor. In addition,
> the E-DMAC reads the next descriptor and prepares for reception
> of the next frame.
> In addition, for get more stable when receiving packets, I set
> maximum size for the transmit/receive FIFO and inserts padding
> in receive data.
> Signed-off-by: Nguyen Hong Ky <nh-ky@jinso.co.jp>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index a753928..11d34f0 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -649,12 +649,16 @@ static struct sh_eth_cpu_data r8a7740_data = {
> .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT |
> EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE |
> EESR_TDE | EESR_ECI,
> + .fdr_value = 0x0000070f,
> + .rmcr_value = 0x00000001,
>
> .apr = 1,
> .mpr = 1,
> .tpauser = 1,
> .bculr = 1,
> .hw_swap = 1,
> + .rpadir = 1,
> + .rpadir_value = 2 << 16,
> .no_trimd = 1,
> .no_ade = 1,
> .tsu = 1,
Guennadi, could you check if this patch fixes your issue with NFS. Make
sure it applies to 'r8a7740_data' (it was misapplied to DaveM's tree).
WBR, Sergei
next prev parent reply other threads:[~2013-10-12 15:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 6:29 [PATCH] net: sh_eth: Fix RX packets errors on R8A7740 Nguyen Hong Ky
2013-10-07 6:29 ` Nguyen Hong Ky
2013-10-09 4:28 ` Simon Horman
2013-10-09 5:26 ` Simon Horman
2013-10-09 5:38 ` Nguyen Hong Ky
2013-10-10 5:29 ` Simon Horman
2013-10-12 16:58 ` Sergei Shtylyov [this message]
2013-10-15 7:28 ` Guennadi Liakhovetski
2013-10-15 21:48 ` Sergei Shtylyov
2013-10-16 5:37 ` Guennadi Liakhovetski
2013-10-08 20:04 ` David Miller
2013-10-09 4:24 ` Simon Horman
2013-10-09 20:27 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52597FC0.4090801@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
--cc=nh-ky@jinso.co.jp \
--cc=ryusuke.sakato.bx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).