* [PATCH] net: sctp: fix a cacc_saw_newack missetting issue
@ 2013-10-14 13:33 Chang Xiangzhong
2013-10-15 14:11 ` Vlad Yasevich
0 siblings, 1 reply; 5+ messages in thread
From: Chang Xiangzhong @ 2013-10-14 13:33 UTC (permalink / raw)
To: nhorman, vyasevich
Cc: davem, linux-sctp, netdev, linux-kernel, Chang Xiangzhong
For for each TSN t being newly acked (Not only cumulatively,
but also SELECTIVELY) cacc_saw_newack should be set to 1.
Signed-off-by: Xiangzhong Chang <changxiangzhong@gmail.com>
---
net/sctp/outqueue.c | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
index 94df758..d86032b 100644
--- a/net/sctp/outqueue.c
+++ b/net/sctp/outqueue.c
@@ -1398,6 +1398,27 @@ static void sctp_check_transmitted(struct sctp_outq *q,
forward_progress = true;
}
+ if (!tchunk->tsn_gap_acked) {
+ /*
+ * SFR-CACC algorithm:
+ * 2) If the SACK contains gap acks
+ * and the flag CHANGEOVER_ACTIVE is
+ * set the receiver of the SACK MUST
+ * take the following action:
+ *
+ * B) For each TSN t being acked that
+ * has not been acked in any SACK so
+ * far, set cacc_saw_newack to 1 for
+ * the destination that the TSN was
+ * sent to.
+ */
+ if (transport &&
+ sack->num_gap_ack_blocks &&
+ q->asoc->peer.primary_path->cacc.
+ changeover_active)
+ transport->cacc.cacc_saw_newack = 1;
+ }
+
if (TSN_lte(tsn, sack_ctsn)) {
/* RFC 2960 6.3.2 Retransmission Timer Rules
*
@@ -1411,27 +1432,6 @@ static void sctp_check_transmitted(struct sctp_outq *q,
restart_timer = 1;
forward_progress = true;
- if (!tchunk->tsn_gap_acked) {
- /*
- * SFR-CACC algorithm:
- * 2) If the SACK contains gap acks
- * and the flag CHANGEOVER_ACTIVE is
- * set the receiver of the SACK MUST
- * take the following action:
- *
- * B) For each TSN t being acked that
- * has not been acked in any SACK so
- * far, set cacc_saw_newack to 1 for
- * the destination that the TSN was
- * sent to.
- */
- if (transport &&
- sack->num_gap_ack_blocks &&
- q->asoc->peer.primary_path->cacc.
- changeover_active)
- transport->cacc.cacc_saw_newack
- = 1;
- }
list_add_tail(&tchunk->transmitted_list,
&q->sacked);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: sctp: fix a cacc_saw_newack missetting issue
2013-10-14 13:33 [PATCH] net: sctp: fix a cacc_saw_newack missetting issue Chang Xiangzhong
@ 2013-10-15 14:11 ` Vlad Yasevich
2013-10-15 14:27 ` Chang
0 siblings, 1 reply; 5+ messages in thread
From: Vlad Yasevich @ 2013-10-15 14:11 UTC (permalink / raw)
To: Chang Xiangzhong, nhorman; +Cc: davem, linux-sctp, netdev, linux-kernel
On 10/14/2013 09:33 AM, Chang Xiangzhong wrote:
> For for each TSN t being newly acked (Not only cumulatively,
> but also SELECTIVELY) cacc_saw_newack should be set to 1.
>
> Signed-off-by: Xiangzhong Chang <changxiangzhong@gmail.com>
> ---
> net/sctp/outqueue.c | 42 +++++++++++++++++++++---------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
> index 94df758..d86032b 100644
> --- a/net/sctp/outqueue.c
> +++ b/net/sctp/outqueue.c
> @@ -1398,6 +1398,27 @@ static void sctp_check_transmitted(struct sctp_outq *q,
> forward_progress = true;
> }
>
> + if (!tchunk->tsn_gap_acked) {
You can remove this test since the block just above already performs
it. Just fold this code into the block above.
-vlad
> + /*
> + * SFR-CACC algorithm:
> + * 2) If the SACK contains gap acks
> + * and the flag CHANGEOVER_ACTIVE is
> + * set the receiver of the SACK MUST
> + * take the following action:
> + *
> + * B) For each TSN t being acked that
> + * has not been acked in any SACK so
> + * far, set cacc_saw_newack to 1 for
> + * the destination that the TSN was
> + * sent to.
> + */
> + if (transport &&
> + sack->num_gap_ack_blocks &&
> + q->asoc->peer.primary_path->cacc.
> + changeover_active)
> + transport->cacc.cacc_saw_newack = 1;
> + }
> +
> if (TSN_lte(tsn, sack_ctsn)) {
> /* RFC 2960 6.3.2 Retransmission Timer Rules
> *
> @@ -1411,27 +1432,6 @@ static void sctp_check_transmitted(struct sctp_outq *q,
> restart_timer = 1;
> forward_progress = true;
>
> - if (!tchunk->tsn_gap_acked) {
> - /*
> - * SFR-CACC algorithm:
> - * 2) If the SACK contains gap acks
> - * and the flag CHANGEOVER_ACTIVE is
> - * set the receiver of the SACK MUST
> - * take the following action:
> - *
> - * B) For each TSN t being acked that
> - * has not been acked in any SACK so
> - * far, set cacc_saw_newack to 1 for
> - * the destination that the TSN was
> - * sent to.
> - */
> - if (transport &&
> - sack->num_gap_ack_blocks &&
> - q->asoc->peer.primary_path->cacc.
> - changeover_active)
> - transport->cacc.cacc_saw_newack
> - = 1;
> - }
>
> list_add_tail(&tchunk->transmitted_list,
> &q->sacked);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: sctp: fix a cacc_saw_newack missetting issue
2013-10-15 14:11 ` Vlad Yasevich
@ 2013-10-15 14:27 ` Chang
2013-10-15 14:34 ` Vlad Yasevich
0 siblings, 1 reply; 5+ messages in thread
From: Chang @ 2013-10-15 14:27 UTC (permalink / raw)
To: Vlad Yasevich, nhorman; +Cc: davem, linux-sctp, netdev, linux-kernel
On 10/15/2013 04:11 PM, Vlad Yasevich wrote:
> On 10/14/2013 09:33 AM, Chang Xiangzhong wrote:
>> For for each TSN t being newly acked (Not only cumulatively,
>> but also SELECTIVELY) cacc_saw_newack should be set to 1.
>>
>> Signed-off-by: Xiangzhong Chang <changxiangzhong@gmail.com>
>> ---
>> net/sctp/outqueue.c | 42 +++++++++++++++++++++---------------------
>> 1 file changed, 21 insertions(+), 21 deletions(-)
>>
>> diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
>> index 94df758..d86032b 100644
>> --- a/net/sctp/outqueue.c
>> +++ b/net/sctp/outqueue.c
>> @@ -1398,6 +1398,27 @@ static void sctp_check_transmitted(struct
>> sctp_outq *q,
>> forward_progress = true;
>> }
>>
>> + if (!tchunk->tsn_gap_acked) {
>
> You can remove this test since the block just above already performs
> it. Just fold this code into the block above.
>
> -vlad
>
Sorry, I'm not sure if I fully understand you. There are code blocks
which checking the tchunk->tsn_gap_acked. In addition, they check other
states as well.
>> + /*
>> + * SFR-CACC algorithm:
>> + * 2) If the SACK contains gap acks
>> + * and the flag CHANGEOVER_ACTIVE is
>> + * set the receiver of the SACK MUST
>> + * take the following action:
>> + *
>> + * B) For each TSN t being acked that
>> + * has not been acked in any SACK so
>> + * far, set cacc_saw_newack to 1 for
>> + * the destination that the TSN was
>> + * sent to.
>> + */
>> + if (transport &&
>> + sack->num_gap_ack_blocks &&
>> + q->asoc->peer.primary_path->cacc.
>> + changeover_active)
>> + transport->cacc.cacc_saw_newack = 1;
>> + }
>> +
>> if (TSN_lte(tsn, sack_ctsn)) {
>> /* RFC 2960 6.3.2 Retransmission Timer Rules
>> *
>> @@ -1411,27 +1432,6 @@ static void sctp_check_transmitted(struct
>> sctp_outq *q,
>> restart_timer = 1;
>> forward_progress = true;
>>
>> - if (!tchunk->tsn_gap_acked) {
>> - /*
>> - * SFR-CACC algorithm:
>> - * 2) If the SACK contains gap acks
>> - * and the flag CHANGEOVER_ACTIVE is
>> - * set the receiver of the SACK MUST
>> - * take the following action:
>> - *
>> - * B) For each TSN t being acked that
>> - * has not been acked in any SACK so
>> - * far, set cacc_saw_newack to 1 for
>> - * the destination that the TSN was
>> - * sent to.
>> - */
>> - if (transport &&
>> - sack->num_gap_ack_blocks &&
>> - q->asoc->peer.primary_path->cacc.
>> - changeover_active)
>> - transport->cacc.cacc_saw_newack
>> - = 1;
>> - }
>>
>> list_add_tail(&tchunk->transmitted_list,
>> &q->sacked);
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: sctp: fix a cacc_saw_newack missetting issue
2013-10-15 14:27 ` Chang
@ 2013-10-15 14:34 ` Vlad Yasevich
2013-10-15 15:13 ` Chang
0 siblings, 1 reply; 5+ messages in thread
From: Vlad Yasevich @ 2013-10-15 14:34 UTC (permalink / raw)
To: Chang, nhorman; +Cc: davem, linux-sctp, netdev, linux-kernel
On 10/15/2013 10:27 AM, Chang wrote:
>
> On 10/15/2013 04:11 PM, Vlad Yasevich wrote:
>> On 10/14/2013 09:33 AM, Chang Xiangzhong wrote:
>>> For for each TSN t being newly acked (Not only cumulatively,
>>> but also SELECTIVELY) cacc_saw_newack should be set to 1.
>>>
>>> Signed-off-by: Xiangzhong Chang <changxiangzhong@gmail.com>
>>> ---
>>> net/sctp/outqueue.c | 42 +++++++++++++++++++++---------------------
>>> 1 file changed, 21 insertions(+), 21 deletions(-)
>>>
>>> diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
>>> index 94df758..d86032b 100644
>>> --- a/net/sctp/outqueue.c
>>> +++ b/net/sctp/outqueue.c
>>> @@ -1398,6 +1398,27 @@ static void sctp_check_transmitted(struct
>>> sctp_outq *q,
>>> forward_progress = true;
>>> }
>>>
>>> + if (!tchunk->tsn_gap_acked) {
>>
>> You can remove this test since the block just above already performs
>> it. Just fold this code into the block above.
>>
>> -vlad
>>
> Sorry, I'm not sure if I fully understand you. There are code blocks
> which checking the tchunk->tsn_gap_acked. In addition, they check other
> states as well.
The flow is:
if (sctp_acked(sack, tsn)) {
...
if (transport) {
....
}
if (!tchunk->tsn_gap_acked) {
....
}
if (TSN_lte(tsn, sack_ctsn)) {
....
/* SFR-CACC ...
}
Since you are moving this up, you can simply re-use
the if (!tchunk->tsn_gap_acked) immediately above.
>>> + /*
>>> + * SFR-CACC algorithm:
>>> + * 2) If the SACK contains gap acks
>>> + * and the flag CHANGEOVER_ACTIVE is
>>> + * set the receiver of the SACK MUST
>>> + * take the following action:
>>> + *
>>> + * B) For each TSN t being acked that
>>> + * has not been acked in any SACK so
>>> + * far, set cacc_saw_newack to 1 for
>>> + * the destination that the TSN was
>>> + * sent to.
>>> + */
>>> + if (transport &&
>>> + sack->num_gap_ack_blocks &&
>>> + q->asoc->peer.primary_path->cacc.
>>> + changeover_active)
>>> + transport->cacc.cacc_saw_newack = 1;
^^^^
Don't need that many spaces...
-vlad
>>> + }
>>> +
>>> if (TSN_lte(tsn, sack_ctsn)) {
>>> /* RFC 2960 6.3.2 Retransmission Timer Rules
>>> *
>>> @@ -1411,27 +1432,6 @@ static void sctp_check_transmitted(struct
>>> sctp_outq *q,
>>> restart_timer = 1;
>>> forward_progress = true;
>>>
>>> - if (!tchunk->tsn_gap_acked) {
>>> - /*
>>> - * SFR-CACC algorithm:
>>> - * 2) If the SACK contains gap acks
>>> - * and the flag CHANGEOVER_ACTIVE is
>>> - * set the receiver of the SACK MUST
>>> - * take the following action:
>>> - *
>>> - * B) For each TSN t being acked that
>>> - * has not been acked in any SACK so
>>> - * far, set cacc_saw_newack to 1 for
>>> - * the destination that the TSN was
>>> - * sent to.
>>> - */
>>> - if (transport &&
>>> - sack->num_gap_ack_blocks &&
>>> - q->asoc->peer.primary_path->cacc.
>>> - changeover_active)
>>> - transport->cacc.cacc_saw_newack
>>> - = 1;
>>> - }
>>>
>>> list_add_tail(&tchunk->transmitted_list,
>>> &q->sacked);
>>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: sctp: fix a cacc_saw_newack missetting issue
2013-10-15 14:34 ` Vlad Yasevich
@ 2013-10-15 15:13 ` Chang
0 siblings, 0 replies; 5+ messages in thread
From: Chang @ 2013-10-15 15:13 UTC (permalink / raw)
To: Vlad Yasevich, nhorman; +Cc: davem, linux-sctp, netdev, linux-kernel
Thanks, I've got it and will submit a new patch later.
On 10/15/2013 04:34 PM, Vlad Yasevich wrote:
> On 10/15/2013 10:27 AM, Chang wrote:
>>
>> On 10/15/2013 04:11 PM, Vlad Yasevich wrote:
>>> On 10/14/2013 09:33 AM, Chang Xiangzhong wrote:
>>>> For for each TSN t being newly acked (Not only cumulatively,
>>>> but also SELECTIVELY) cacc_saw_newack should be set to 1.
>>>>
>>>> Signed-off-by: Xiangzhong Chang <changxiangzhong@gmail.com>
>>>> ---
>>>> net/sctp/outqueue.c | 42
>>>> +++++++++++++++++++++---------------------
>>>> 1 file changed, 21 insertions(+), 21 deletions(-)
>>>>
>>>> diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
>>>> index 94df758..d86032b 100644
>>>> --- a/net/sctp/outqueue.c
>>>> +++ b/net/sctp/outqueue.c
>>>> @@ -1398,6 +1398,27 @@ static void sctp_check_transmitted(struct
>>>> sctp_outq *q,
>>>> forward_progress = true;
>>>> }
>>>>
>>>> + if (!tchunk->tsn_gap_acked) {
>>>
>>> You can remove this test since the block just above already performs
>>> it. Just fold this code into the block above.
>>>
>>> -vlad
>>>
>> Sorry, I'm not sure if I fully understand you. There are code blocks
>> which checking the tchunk->tsn_gap_acked. In addition, they check other
>> states as well.
>
> The flow is:
>
> if (sctp_acked(sack, tsn)) {
> ...
> if (transport) {
> ....
> }
>
> if (!tchunk->tsn_gap_acked) {
> ....
> }
>
> if (TSN_lte(tsn, sack_ctsn)) {
> ....
> /* SFR-CACC ...
> }
>
> Since you are moving this up, you can simply re-use
> the if (!tchunk->tsn_gap_acked) immediately above.
>
>>>> + /*
>>>> + * SFR-CACC algorithm:
>>>> + * 2) If the SACK contains gap acks
>>>> + * and the flag CHANGEOVER_ACTIVE is
>>>> + * set the receiver of the SACK MUST
>>>> + * take the following action:
>>>> + *
>>>> + * B) For each TSN t being acked that
>>>> + * has not been acked in any SACK so
>>>> + * far, set cacc_saw_newack to 1 for
>>>> + * the destination that the TSN was
>>>> + * sent to.
>>>> + */
>>>> + if (transport &&
>>>> + sack->num_gap_ack_blocks &&
>>>> + q->asoc->peer.primary_path->cacc.
>>>> + changeover_active)
>>>> + transport->cacc.cacc_saw_newack = 1;
> ^^^^
>
> Don't need that many spaces...
>
> -vlad
>>>> + }
>>>> +
>>>> if (TSN_lte(tsn, sack_ctsn)) {
>>>> /* RFC 2960 6.3.2 Retransmission Timer Rules
>>>> *
>>>> @@ -1411,27 +1432,6 @@ static void sctp_check_transmitted(struct
>>>> sctp_outq *q,
>>>> restart_timer = 1;
>>>> forward_progress = true;
>>>>
>>>> - if (!tchunk->tsn_gap_acked) {
>>>> - /*
>>>> - * SFR-CACC algorithm:
>>>> - * 2) If the SACK contains gap acks
>>>> - * and the flag CHANGEOVER_ACTIVE is
>>>> - * set the receiver of the SACK MUST
>>>> - * take the following action:
>>>> - *
>>>> - * B) For each TSN t being acked that
>>>> - * has not been acked in any SACK so
>>>> - * far, set cacc_saw_newack to 1 for
>>>> - * the destination that the TSN was
>>>> - * sent to.
>>>> - */
>>>> - if (transport &&
>>>> - sack->num_gap_ack_blocks &&
>>>> - q->asoc->peer.primary_path->cacc.
>>>> - changeover_active)
>>>> - transport->cacc.cacc_saw_newack
>>>> - = 1;
>>>> - }
>>>>
>>>> list_add_tail(&tchunk->transmitted_list,
>>>> &q->sacked);
>>>>
>>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-15 15:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-14 13:33 [PATCH] net: sctp: fix a cacc_saw_newack missetting issue Chang Xiangzhong
2013-10-15 14:11 ` Vlad Yasevich
2013-10-15 14:27 ` Chang
2013-10-15 14:34 ` Vlad Yasevich
2013-10-15 15:13 ` Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).