From: Fan Du <fan.du@windriver.com>
To: Vlad Yasevich <vyasevich@gmail.com>
Cc: <nhorman@tuxdriver.com>, <steffen.klassert@secunet.com>,
<davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCHv3 net] {xfrm, sctp} Stick to software crc32 even if hardware is capable of that
Date: Wed, 16 Oct 2013 09:58:03 +0800 [thread overview]
Message-ID: <525DF2AB.1050806@windriver.com> (raw)
In-Reply-To: <525DF141.6060302@gmail.com>
On 2013年10月16日 09:52, Vlad Yasevich wrote:
> On 10/15/2013 09:05 PM, Vlad Yasevich wrote:
>> On 10/15/2013 05:19 AM, Fan Du wrote:
>>> igb/ixgbe have hardware sctp checksum support, when this feature is
>>> enabled
>>> and also IPsec is armed to protect sctp traffic, ugly things happened as
>>> xfrm_output checks CHECKSUM_PARTIAL to do check sum operation(sum
>>> every thing
>>> up and pack the 16bits result in the checksum field). The result is fail
>>> establishment of sctp communication.
>>>
>>> Signed-off-by: Fan Du <fan.du@windriver.com>
>>> Cc: Vlad Yasevich <vyasevich@gmail.com>
>>> Cc: Neil Horman <nhorman@tuxdriver.com>
>>> Cc: Steffen Klassert <steffen.klassert@secunet.com>
>>> Acked-by: Vlad Yasevich <vyasevich@gmail.com>
>>
>> Looks good to me.
>>
>
> Just tryied applying this and looks like you based this on net-next.
> This fixes a rather ugly bug when checksum offloading is done.
> I am going to rebase this and re-submit for net.
:( Sorry for the inconvenience. Stable tree might hurts also.
--
浮沉随浪只记今朝笑
--fan
prev parent reply other threads:[~2013-10-16 2:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 9:19 [PATCHv3 net] {xfrm, sctp} Stick to software crc32 even if hardware is capable of that Fan Du
2013-10-16 1:05 ` Vlad Yasevich
2013-10-16 1:52 ` Vlad Yasevich
2013-10-16 1:58 ` Fan Du [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525DF2AB.1050806@windriver.com \
--to=fan.du@windriver.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=steffen.klassert@secunet.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).