From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
a@vger.kernel.org, davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [net-next 03/14] i40e: assign correct vector to VF
Date: Fri, 18 Oct 2013 18:08:30 +0400 [thread overview]
Message-ID: <526140DE.8000009@cogentembedded.com> (raw)
In-Reply-To: <1382102598-11343-4-git-send-email-jeffrey.t.kirsher@intel.com>
Hello.
On 18-10-2013 17:23, Jeff Kirsher wrote:
> From: Mitch Williams <mitch.a.williams@intel.com>
> Correct math error when assigning MSI-X vectors to VFs. The vectors-per-vf
> value reported by the hardware already conveniently reports one less than the
> actual value.
> Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Tested-by: Sibai Li <sibai.li@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> index 8967e58..202139f 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> @@ -251,7 +251,7 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_idx,
> reg_idx = I40E_VPINT_LNKLST0(vf->vf_id);
> else
> reg_idx = I40E_VPINT_LNKLSTN(
> - ((pf->hw.func_caps.num_msix_vectors_vf - 1)
> + ((pf->hw.func_caps.num_msix_vectors_vf)
Why keep the parens if you've removed -1?
WBR, Sergei
next prev parent reply other threads:[~2013-10-18 14:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 13:23 [net-next 00/14][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-10-18 13:23 ` [net-next 01/14] i40e: do not flush after re-enabling interrupts Jeff Kirsher
2013-10-18 13:23 ` [net-next 02/14] i40e: don't free nonexistent rings Jeff Kirsher
2013-10-18 13:23 ` [net-next 03/14] i40e: assign correct vector to VF Jeff Kirsher
2013-10-18 14:08 ` Sergei Shtylyov [this message]
2013-10-18 13:23 ` [net-next 04/14] i40e: fixup legacy interrupt handling Jeff Kirsher
2013-10-18 13:23 ` [net-next 05/14] i40e: debugfs fixups Jeff Kirsher
2013-10-18 13:23 ` [net-next 06/14] i40e: clamp debugfs nvm read command Jeff Kirsher
2013-10-18 13:23 ` [net-next 07/14] i40e: fix use of untrusted scalar value warning Jeff Kirsher
2013-10-18 13:23 ` [net-next 08/14] i40e: fix sign extension issue Jeff Kirsher
2013-10-18 13:23 ` [net-next 09/14] i40e: refactor fdir setup function Jeff Kirsher
2013-10-18 13:23 ` [net-next 10/14] i40e: tweaking icr0 handling for legacy irq Jeff Kirsher
2013-10-18 13:23 ` [net-next 11/14] i40e: reorder block declarations in debugfs Jeff Kirsher
2013-10-18 14:13 ` Sergei Shtylyov
2013-10-18 14:34 ` Jeff Kirsher
2013-10-18 17:38 ` David Miller
2013-10-18 17:42 ` Jeff Kirsher
2013-10-18 13:23 ` [net-next 12/14] i40e: check vsi ptrs before dumping them Jeff Kirsher
2013-10-18 13:23 ` [net-next 13/14] i40e: use pf_id for pf function id in qtx_ctl Jeff Kirsher
2013-10-18 13:23 ` [net-next 14/14] i40e: Bump version Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526140DE.8000009@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=a@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).