From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/9 RESENT] staging: r8188eu: Set device type to wlan Date: Sat, 19 Oct 2013 01:58:41 +0400 Message-ID: <5261AF11.2090004@cogentembedded.com> References: <1382129563-8496-1-git-send-email-Larry.Finger@lwfinger.net> <5261A904.9030908@lwfinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev , devel@driverdev.osuosl.org To: Larry Finger , gregkh@linuxfoundation.org Return-path: Received: from mail-lb0-f177.google.com ([209.85.217.177]:48696 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754406Ab3JRV7j (ORCPT ); Fri, 18 Oct 2013 17:59:39 -0400 Received: by mail-lb0-f177.google.com with SMTP id u14so920757lbd.36 for ; Fri, 18 Oct 2013 14:59:38 -0700 (PDT) In-Reply-To: <5261A904.9030908@lwfinger.net> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 10/19/2013 01:32 AM, Larry Finger wrote: > The latest version of NetworkManager does not recognize the device as wireless > without this change. > Signed-off-by: Larry Finger > --- > drivers/staging/rtl8188eu/os_dep/os_intfs.c | 5 +++++ > 1 file changed, 5 insertions(+) > diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c > b/drivers/staging/rtl8188eu/os_dep/os_intfs.c > index da9f0d5..17659bb 100644 > --- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c > +++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c > @@ -707,6 +707,10 @@ int rtw_init_netdev_name(struct net_device *pnetdev, > const char *ifname) > return 0; > } > +static const struct device_type wlan_type = { Hm, a space got added before +, so the patch was somehow broken. > + .name = "wlan", > +}; > + > struct net_device *rtw_init_netdev(struct adapter *old_padapter) > { > struct adapter *padapter; > @@ -722,6 +726,7 @@ struct net_device *rtw_init_netdev(struct adapter > *old_padapter) > if (!pnetdev) > return NULL; > + pnetdev->dev.type = &wlan_type; Here too. WBR, Sergei