From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Subject: Re: [PATCH] davinci_emac.c: Fix IFF_ALLMULTI setup Date: Mon, 21 Oct 2013 23:20:41 +0530 Message-ID: <52656971.3020509@ti.com> References: <5265640C.4070201@cogentembedded.com> <1382377504-24688-1-git-send-email-mceier+kernel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Lad Prabhakar , Jingoo Han , Jiri Pirko , , To: Mariusz Ceier Return-path: In-Reply-To: <1382377504-24688-1-git-send-email-mceier+kernel@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Monday 21 October 2013 11:15 PM, Mariusz Ceier wrote: > When IFF_ALLMULTI flag is set on interface and IFF_PROMISC isn't, > emac_dev_mcast_set should only enable RX of multicasts and reset > MACHASH registers. > > It does this, but afterwards it either sets up multicast MACs > filtering or disables RX of multicasts and resets MACHASH registers > again, rendering IFF_ALLMULTI flag useless. > > This patch fixes emac_dev_mcast_set, so that multicast MACs filtering and > disabling of RX of multicasts are skipped when IFF_ALLMULTI flag is set. > > Tested with kernel 2.6.37. > > Signed-off-by: Mariusz Ceier > --- Can you add [PATCH v2] in your subject in future so that it will be easier to the maintainer to pick the latest version of the patch. Acked-by: Mugunthan V N Regards Mugunthan V N