* [PATCH net v3] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver
@ 2013-10-23 8:19 Somnath Kotur
2013-10-23 11:29 ` Somnath Kotur
0 siblings, 1 reply; 4+ messages in thread
From: Somnath Kotur @ 2013-10-23 8:19 UTC (permalink / raw)
To: netdev; +Cc: davem, Somnath Kotur
On very old FW versions < 4.0, the mailbox command to set interrupts
on the card succeeds even though it is not supported and should have
failed, leading to a scenario where interrupts do not work.
Hence warn users to upgrade to a suitable FW version to avoid seeing
broken functionality.
Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
---
v3: Incorporated comments from Ben Hutchings and Joe Perches
drivers/net/ethernet/emulex/benet/be.h | 14 ++++++++++++++
drivers/net/ethernet/emulex/benet/be_main.c | 6 ++++++
2 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index db02023..6a57051 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -696,6 +696,20 @@ static inline int qnq_async_evt_rcvd(struct be_adapter *adapter)
return adapter->flags & BE_FLAGS_QNQ_ASYNC_EVT_RCVD;
}
+static inline u32 fw_major_num(char *fw_ver_str)
+{
+ u32 fw_major;
+ char *next, *cp;
+ char tmp_fw_ver[FW_VER_LEN];
+
+ strncpy(tmp_fw_ver, fw_ver_str, strlen(fw_ver_str));
+ next = tmp_fw_ver;
+ cp = strsep(&next, ".");
+ sscanf(cp, "%i", &fw_major);
+
+ return fw_major;
+}
+
extern void be_cq_notify(struct be_adapter *adapter, u16 qid, bool arm,
u16 num_popped);
extern void be_link_status_update(struct be_adapter *adapter, u8 link_status);
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 2c38cc4..d8da961 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3247,6 +3247,12 @@ static int be_setup(struct be_adapter *adapter)
be_cmd_get_fw_ver(adapter, adapter->fw_ver, adapter->fw_on_flash);
+ if (BE2_chip(adapter) && fw_major_num(adapter->fw_ver) < 4) {
+ dev_err(dev, "Firmware on card is old(%s), IRQs may not work.",
+ adapter->fw_ver);
+ dev_err(dev, "Please upgrade firmware to version >= 4.0\n");
+ }
+
if (adapter->vlans_added)
be_vid_config(adapter);
--
1.6.0.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH net v3] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver
2013-10-23 8:19 Somnath Kotur
@ 2013-10-23 11:29 ` Somnath Kotur
0 siblings, 0 replies; 4+ messages in thread
From: Somnath Kotur @ 2013-10-23 11:29 UTC (permalink / raw)
To: Somnath Kotur, netdev@vger.kernel.org; +Cc: davem@davemloft.net
Pls ignore this, sent this version out by mistake , will resend the correct one soon after this, extremely sorry for the inconvenience.
Thanks
Somnath
> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Somnath Kotur
> Sent: Wednesday, October 23, 2013 1:49 PM
> To: netdev@vger.kernel.org
> Cc: davem@davemloft.net; Somnath Kotur
> Subject: [PATCH net v3] be2net: Warn users of possible broken functionality
> on BE2 cards with very old FW versions with latest driver
>
> On very old FW versions < 4.0, the mailbox command to set interrupts on the
> card succeeds even though it is not supported and should have failed,
> leading to a scenario where interrupts do not work.
> Hence warn users to upgrade to a suitable FW version to avoid seeing broken
> functionality.
>
> Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
> ---
> v3: Incorporated comments from Ben Hutchings and Joe Perches
>
> drivers/net/ethernet/emulex/benet/be.h | 14 ++++++++++++++
> drivers/net/ethernet/emulex/benet/be_main.c | 6 ++++++
> 2 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be.h
> b/drivers/net/ethernet/emulex/benet/be.h
> index db02023..6a57051 100644
> --- a/drivers/net/ethernet/emulex/benet/be.h
> +++ b/drivers/net/ethernet/emulex/benet/be.h
> @@ -696,6 +696,20 @@ static inline int qnq_async_evt_rcvd(struct
> be_adapter *adapter)
> return adapter->flags & BE_FLAGS_QNQ_ASYNC_EVT_RCVD; }
>
> +static inline u32 fw_major_num(char *fw_ver_str) {
> + u32 fw_major;
> + char *next, *cp;
> + char tmp_fw_ver[FW_VER_LEN];
> +
> + strncpy(tmp_fw_ver, fw_ver_str, strlen(fw_ver_str));
> + next = tmp_fw_ver;
> + cp = strsep(&next, ".");
> + sscanf(cp, "%i", &fw_major);
> +
> + return fw_major;
> +}
> +
> extern void be_cq_notify(struct be_adapter *adapter, u16 qid, bool arm,
> u16 num_popped);
> extern void be_link_status_update(struct be_adapter *adapter, u8
> link_status); diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
> b/drivers/net/ethernet/emulex/benet/be_main.c
> index 2c38cc4..d8da961 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -3247,6 +3247,12 @@ static int be_setup(struct be_adapter *adapter)
>
> be_cmd_get_fw_ver(adapter, adapter->fw_ver, adapter-
> >fw_on_flash);
>
> + if (BE2_chip(adapter) && fw_major_num(adapter->fw_ver) < 4) {
> + dev_err(dev, "Firmware on card is old(%s), IRQs may not
> work.",
> + adapter->fw_ver);
> + dev_err(dev, "Please upgrade firmware to version >=
> 4.0\n");
> + }
> +
> if (adapter->vlans_added)
> be_vid_config(adapter);
>
> --
> 1.6.0.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the body
> of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net v3] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver
@ 2013-10-23 11:29 Somnath Kotur
2013-10-24 8:37 ` Ivan Vecera
0 siblings, 1 reply; 4+ messages in thread
From: Somnath Kotur @ 2013-10-23 11:29 UTC (permalink / raw)
To: netdev; +Cc: davem, Somnath Kotur
On very old FW versions < 4.0, the mailbox command to set interrupts
on the card succeeds even though it is not supported and should have
failed, leading to a scenario where interrupts do not work.
Hence warn users to upgrade to a suitable FW version to avoid seeing
broken functionality.
Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
---
v3: Incorporated comments from Ben Hutchings, Joe Perches and Ivan Vercera
drivers/net/ethernet/emulex/benet/be.h | 9 +++++++++
drivers/net/ethernet/emulex/benet/be_main.c | 6 ++++++
2 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index db02023..da9c04b 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -696,6 +696,15 @@ static inline int qnq_async_evt_rcvd(struct be_adapter *adapter)
return adapter->flags & BE_FLAGS_QNQ_ASYNC_EVT_RCVD;
}
+static inline u32 fw_major_num(const char *fw_ver)
+{
+ int fw_major = 0;
+
+ sscanf(fw_ver, "%d.", &fw_major);
+
+ return fw_major;
+}
+
extern void be_cq_notify(struct be_adapter *adapter, u16 qid, bool arm,
u16 num_popped);
extern void be_link_status_update(struct be_adapter *adapter, u8 link_status);
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 2c38cc4..53ed58b 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3247,6 +3247,12 @@ static int be_setup(struct be_adapter *adapter)
be_cmd_get_fw_ver(adapter, adapter->fw_ver, adapter->fw_on_flash);
+ if (BE2_chip(adapter) && fw_major_num(adapter->fw_ver) < 4) {
+ dev_err(dev, "Firmware on card is old(%s), IRQs may not work",
+ adapter->fw_ver);
+ dev_err(dev, "Please upgrade firmware to version >= 4.0\n");
+ }
+
if (adapter->vlans_added)
be_vid_config(adapter);
--
1.6.0.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net v3] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver
2013-10-23 11:29 [PATCH net v3] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver Somnath Kotur
@ 2013-10-24 8:37 ` Ivan Vecera
0 siblings, 0 replies; 4+ messages in thread
From: Ivan Vecera @ 2013-10-24 8:37 UTC (permalink / raw)
To: Somnath Kotur; +Cc: netdev, davem
Hi Som,
see my inline comment below...
Ivan
On 10/23/2013 01:29 PM, Somnath Kotur wrote:
> On very old FW versions < 4.0, the mailbox command to set interrupts
> on the card succeeds even though it is not supported and should have
> failed, leading to a scenario where interrupts do not work.
> Hence warn users to upgrade to a suitable FW version to avoid seeing
> broken functionality.
>
> Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
> ---
> v3: Incorporated comments from Ben Hutchings, Joe Perches and Ivan Vercera
>
> drivers/net/ethernet/emulex/benet/be.h | 9 +++++++++
> drivers/net/ethernet/emulex/benet/be_main.c | 6 ++++++
> 2 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
> index db02023..da9c04b 100644
> --- a/drivers/net/ethernet/emulex/benet/be.h
> +++ b/drivers/net/ethernet/emulex/benet/be.h
> @@ -696,6 +696,15 @@ static inline int qnq_async_evt_rcvd(struct be_adapter *adapter)
> return adapter->flags & BE_FLAGS_QNQ_ASYNC_EVT_RCVD;
> }
>
> +static inline u32 fw_major_num(const char *fw_ver)
> +{
> + int fw_major = 0;
> +
> + sscanf(fw_ver, "%d.", &fw_major);
> +
> + return fw_major;
> +}
> +
You changed fw_major as I mentioned in our private discussion but the
return type should be also 'int' and not 'u32'.
> extern void be_cq_notify(struct be_adapter *adapter, u16 qid, bool arm,
> u16 num_popped);
> extern void be_link_status_update(struct be_adapter *adapter, u8 link_status);
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index 2c38cc4..53ed58b 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -3247,6 +3247,12 @@ static int be_setup(struct be_adapter *adapter)
>
> be_cmd_get_fw_ver(adapter, adapter->fw_ver, adapter->fw_on_flash);
>
> + if (BE2_chip(adapter) && fw_major_num(adapter->fw_ver) < 4) {
> + dev_err(dev, "Firmware on card is old(%s), IRQs may not work",
> + adapter->fw_ver);
> + dev_err(dev, "Please upgrade firmware to version >= 4.0\n");
> + }
> +
> if (adapter->vlans_added)
> be_vid_config(adapter);
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-24 8:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-23 11:29 [PATCH net v3] be2net: Warn users of possible broken functionality on BE2 cards with very old FW versions with latest driver Somnath Kotur
2013-10-24 8:37 ` Ivan Vecera
-- strict thread matches above, loose matches on Subject: below --
2013-10-23 8:19 Somnath Kotur
2013-10-23 11:29 ` Somnath Kotur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).