netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jing Wang <windsdaemon@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net:sched  fix a bug about memery leak
Date: Thu, 24 Oct 2013 18:05:14 +0400	[thread overview]
Message-ID: <5269291A.7050406@cogentembedded.com> (raw)
In-Reply-To: <1382605580-2629-1-git-send-email-windsdaemon@gmail.com>

Hello.

On 10/24/2013 01:06 PM, Jing Wang wrote:

> From: Jing Wang <windsdaemon@gmail.com>

> the code isn't properly release memory

> Signed-off-by: Jing Wang <windsdaemon@gmail.com>
> ---
>   net/sched/cls_route.c |    9 ++++++---
>   1 files changed, 6 insertions(+), 3 deletions(-)

> diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c
> index 37da567..118f8d5 100644
> --- a/net/sched/cls_route.c
> +++ b/net/sched/cls_route.c
[...]
> @@ -517,6 +517,9 @@ reinsert:
>
>   errout:
>   	kfree(f);
> +errflt:
> +    kfree(head);

    Please indent with tab, not spaces.

WBR, Sergei

  reply	other threads:[~2013-10-24 14:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24  9:06 [PATCH 1/1] net:sched fix a bug about memery leak Jing Wang
2013-10-24 14:05 ` Sergei Shtylyov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-10-24  9:12 Jing Wang
2013-10-24  9:33 ` Eric Dumazet
2013-10-24 14:07   ` Christoph Paasch
2013-10-24 14:23     ` Christoph Paasch
2013-10-24 14:10 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5269291A.7050406@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=netdev@vger.kernel.org \
    --cc=windsdaemon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).