From: Nikolay Aleksandrov <nikolay@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: David.Laight@ACULAB.COM, vfalico@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] netconsole: fix NULL pointer dereference
Date: Thu, 24 Oct 2013 20:22:27 +0200 [thread overview]
Message-ID: <52696563.1060507@redhat.com> (raw)
In-Reply-To: <20131024.135614.1725589105857635534.davem@davemloft.net>
On 10/24/2013 07:56 PM, David Miller wrote:
> From: "David Laight" <David.Laight@ACULAB.COM>
> Date: Thu, 24 Oct 2013 11:39:02 +0100
>
>>>> Taking the spinlock seems like the cleanest way to insure there's noone
>>>> running in parallel, but I'm open to suggestions as I'm not satisfied with
>>>> the looks of this. I'll prepare a net-next patchset for netconsole soon to
>>>> clean it up properly, all of these can be easily simplified.
>>>
>>> First when I've seen 'spin_lock(); a = 1; spin_unlock()' I've thought
>>> "WTF?", however indeed it will stop us racing with write_msg().
>>
>> Ditto - might be worth saying:
>> /* Acquire lock to wait for any write_msg() to complete. */
>
> Something this subtle definitely requires a comment.
>
Okay, thank you all for the reviews. I will re-submit a v2 with
the comment edited.
Nik
next prev parent reply other threads:[~2013-10-24 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 13:04 [PATCH net] netconsole: fix NULL pointer dereference Nikolay Aleksandrov
2013-10-24 10:21 ` Veaceslav Falico
2013-10-24 10:39 ` David Laight
2013-10-24 17:56 ` David Miller
2013-10-24 18:22 ` Nikolay Aleksandrov [this message]
2013-10-24 20:59 ` Francois Romieu
2013-10-25 14:15 ` Nikolay Aleksandrov
2013-10-25 23:06 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52696563.1060507@redhat.com \
--to=nikolay@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).