From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Tom D'Alba <tomster595@gmail.com>, netdev@vger.kernel.org
Cc: Tom D'Alba <dalbat@rpi.edu>
Subject: Re: [PATCH net-next] jazzsonic: printk() style fixes
Date: Fri, 25 Oct 2013 01:50:34 +0400 [thread overview]
Message-ID: <5269962A.5050306@cogentembedded.com> (raw)
In-Reply-To: <1382650780-24114-1-git-send-email-tomster595@gmail.com>
Hello.
On 10/25/2013 01:39 AM, Tom D'Alba wrote:
> From: Tom D'Alba <dalbat@rpi.edu>
> Fixed printk() format by adding correct KERN_ statuses.
> Reviewed-by: Nicholas Guthrie <nickg4317@gmail.com>
> Reviewed-by: Sarah Williams <swilliams704@gmail.com>
> Reviewed-by: Jason Lee <calccrypto@gmail.com>
> Signed-off-by: Tom D'Alba <dalbat@rpi.edu>
> ---
> drivers/net/ethernet/natsemi/jazzsonic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c
> index 79257f7..3a04d32 100644
> --- a/drivers/net/ethernet/natsemi/jazzsonic.c
> +++ b/drivers/net/ethernet/natsemi/jazzsonic.c
> @@ -135,7 +135,7 @@ static int sonic_probe1(struct net_device *dev)
> */
> silicon_revision = SONIC_READ(SONIC_SR);
> if (sonic_debug > 1)
> - printk("SONIC Silicon Revision = 0x%04x\n",silicon_revision);
> + printk(KERN_INFO "SONIC Silicon Revision = 0x%04x\n",silicon_revision);
Please don't change the indentation.
> @@ -143,13 +143,13 @@ static int sonic_probe1(struct net_device *dev)
> i++;
>
> if (known_revisions[i] == 0xffff) {
> - printk("SONIC ethernet controller not found (0x%4x)\n",
> + printk(KERN_ERR "SONIC ethernet controller not found (0x%4x)\n",
> silicon_revision);
> goto out;
> }
>
> if (sonic_debug && version_printed++ == 0)
> - printk(version);
> + printk(KERN_INFO version);
Same here.
WBR, Sergei
next prev parent reply other threads:[~2013-10-24 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:39 [PATCH net-next] jazzsonic: printk() style fixes Tom D'Alba
2013-10-24 21:50 ` Sergei Shtylyov [this message]
2013-10-24 21:54 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5269962A.5050306@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dalbat@rpi.edu \
--cc=netdev@vger.kernel.org \
--cc=tomster595@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox