* [PATCH net-next] jazzsonic: printk() style fixes
@ 2013-10-24 21:39 Tom D'Alba
2013-10-24 21:50 ` Sergei Shtylyov
2013-10-24 21:54 ` Fabio Estevam
0 siblings, 2 replies; 3+ messages in thread
From: Tom D'Alba @ 2013-10-24 21:39 UTC (permalink / raw)
To: netdev; +Cc: Tom D'Alba
From: Tom D'Alba <dalbat@rpi.edu>
Fixed printk() format by adding correct KERN_ statuses.
Reviewed-by: Nicholas Guthrie <nickg4317@gmail.com>
Reviewed-by: Sarah Williams <swilliams704@gmail.com>
Reviewed-by: Jason Lee <calccrypto@gmail.com>
Signed-off-by: Tom D'Alba <dalbat@rpi.edu>
---
drivers/net/ethernet/natsemi/jazzsonic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c
index 79257f7..3a04d32 100644
--- a/drivers/net/ethernet/natsemi/jazzsonic.c
+++ b/drivers/net/ethernet/natsemi/jazzsonic.c
@@ -135,7 +135,7 @@ static int sonic_probe1(struct net_device *dev)
*/
silicon_revision = SONIC_READ(SONIC_SR);
if (sonic_debug > 1)
- printk("SONIC Silicon Revision = 0x%04x\n",silicon_revision);
+ printk(KERN_INFO "SONIC Silicon Revision = 0x%04x\n",silicon_revision);
i = 0;
while (known_revisions[i] != 0xffff &&
@@ -143,13 +143,13 @@ static int sonic_probe1(struct net_device *dev)
i++;
if (known_revisions[i] == 0xffff) {
- printk("SONIC ethernet controller not found (0x%4x)\n",
+ printk(KERN_ERR "SONIC ethernet controller not found (0x%4x)\n",
silicon_revision);
goto out;
}
if (sonic_debug && version_printed++ == 0)
- printk(version);
+ printk(KERN_INFO version);
printk(KERN_INFO "%s: Sonic ethernet found at 0x%08lx, ",
dev_name(lp->device), dev->base_addr);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] jazzsonic: printk() style fixes
2013-10-24 21:39 [PATCH net-next] jazzsonic: printk() style fixes Tom D'Alba
@ 2013-10-24 21:50 ` Sergei Shtylyov
2013-10-24 21:54 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2013-10-24 21:50 UTC (permalink / raw)
To: Tom D'Alba, netdev; +Cc: Tom D'Alba
Hello.
On 10/25/2013 01:39 AM, Tom D'Alba wrote:
> From: Tom D'Alba <dalbat@rpi.edu>
> Fixed printk() format by adding correct KERN_ statuses.
> Reviewed-by: Nicholas Guthrie <nickg4317@gmail.com>
> Reviewed-by: Sarah Williams <swilliams704@gmail.com>
> Reviewed-by: Jason Lee <calccrypto@gmail.com>
> Signed-off-by: Tom D'Alba <dalbat@rpi.edu>
> ---
> drivers/net/ethernet/natsemi/jazzsonic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c
> index 79257f7..3a04d32 100644
> --- a/drivers/net/ethernet/natsemi/jazzsonic.c
> +++ b/drivers/net/ethernet/natsemi/jazzsonic.c
> @@ -135,7 +135,7 @@ static int sonic_probe1(struct net_device *dev)
> */
> silicon_revision = SONIC_READ(SONIC_SR);
> if (sonic_debug > 1)
> - printk("SONIC Silicon Revision = 0x%04x\n",silicon_revision);
> + printk(KERN_INFO "SONIC Silicon Revision = 0x%04x\n",silicon_revision);
Please don't change the indentation.
> @@ -143,13 +143,13 @@ static int sonic_probe1(struct net_device *dev)
> i++;
>
> if (known_revisions[i] == 0xffff) {
> - printk("SONIC ethernet controller not found (0x%4x)\n",
> + printk(KERN_ERR "SONIC ethernet controller not found (0x%4x)\n",
> silicon_revision);
> goto out;
> }
>
> if (sonic_debug && version_printed++ == 0)
> - printk(version);
> + printk(KERN_INFO version);
Same here.
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] jazzsonic: printk() style fixes
2013-10-24 21:39 [PATCH net-next] jazzsonic: printk() style fixes Tom D'Alba
2013-10-24 21:50 ` Sergei Shtylyov
@ 2013-10-24 21:54 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2013-10-24 21:54 UTC (permalink / raw)
To: Tom D'Alba; +Cc: netdev@vger.kernel.org, Tom D'Alba
Hi Tom,
On Thu, Oct 24, 2013 at 7:39 PM, Tom D'Alba <tomster595@gmail.com> wrote:
> From: Tom D'Alba <dalbat@rpi.edu>
>
> Fixed printk() format by adding correct KERN_ statuses.
>
> Reviewed-by: Nicholas Guthrie <nickg4317@gmail.com>
> Reviewed-by: Sarah Williams <swilliams704@gmail.com>
> Reviewed-by: Jason Lee <calccrypto@gmail.com>
> Signed-off-by: Tom D'Alba <dalbat@rpi.edu>
> ---
> drivers/net/ethernet/natsemi/jazzsonic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c b/drivers/net/ethernet/natsemi/jazzsonic.c
> index 79257f7..3a04d32 100644
> --- a/drivers/net/ethernet/natsemi/jazzsonic.c
> +++ b/drivers/net/ethernet/natsemi/jazzsonic.c
> @@ -135,7 +135,7 @@ static int sonic_probe1(struct net_device *dev)
> */
> silicon_revision = SONIC_READ(SONIC_SR);
> if (sonic_debug > 1)
> - printk("SONIC Silicon Revision = 0x%04x\n",silicon_revision);
> + printk(KERN_INFO "SONIC Silicon Revision = 0x%04x\n",silicon_revision);
You could use netdev_info here instead.
>
> i = 0;
> while (known_revisions[i] != 0xffff &&
> @@ -143,13 +143,13 @@ static int sonic_probe1(struct net_device *dev)
> i++;
>
> if (known_revisions[i] == 0xffff) {
> - printk("SONIC ethernet controller not found (0x%4x)\n",
> + printk(KERN_ERR "SONIC ethernet controller not found (0x%4x)\n",
You could use netdev_err here instead.
> silicon_revision);
> goto out;
> }
>
> if (sonic_debug && version_printed++ == 0)
> - printk(version);
> + printk(KERN_INFO version);
You could use netdev_info here instead.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-24 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-24 21:39 [PATCH net-next] jazzsonic: printk() style fixes Tom D'Alba
2013-10-24 21:50 ` Sergei Shtylyov
2013-10-24 21:54 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox