From: David Cohen <david.a.cohen@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Darren Hart <dvhart@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Alexandre Courbot <acourbot@nvidia.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [gpio:for-next 67/67] pch_gbe_main.c:undefined reference to `devm_gpio_request_one'
Date: Fri, 25 Oct 2013 14:21:47 -0700 [thread overview]
Message-ID: <526AE0EB.4020602@linux.intel.com> (raw)
In-Reply-To: <CACRpkdYDUKK-jAeeHECfRcKM+-MDuyarDMGDP0p39U_-WLgd8w@mail.gmail.com>
Hi Linus,
On 10/25/2013 03:49 AM, Linus Walleij wrote:
> On Fri, Oct 25, 2013 at 12:41 PM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>
>>> I wouldn't object to adding a dependency to GPIO_PCH and GPIOLIB
>>> unconditionally for PCH_GBE as GPIO_PCH is the same chip... but I don't
>>> know if David Miller would be amenable to that.
>>
>> Well we should probably just stick a dependency to GPIOLIB in there.
>>
>> - It #includes <linux/gpio.h>
>> - It uses gpiolib functions to do something vital
>>
>> It was just happy that dummy versions were slotted in until now.
>
> ...or maybe I'm just confused now?
>
> Should we just add a static inline stub of devm_gpio_request_one()?
I am not familiar with the HW. But checking the code, platform
initialization should fail with a dummy devm_gpio_request_one()
implementation. IMO it makes more sense to depend on GPIOLIB.
Br, David Cohen
next prev parent reply other threads:[~2013-10-25 21:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52691c0b.BIIOKlR6F81qU+tE%fengguang.wu@intel.com>
[not found] ` <20131025044027.GA27083@localhost>
[not found] ` <CACRpkdaJVE44UGRAZ0tnQSArrs+DuVFhVssW6riWmdp8-6E6BQ@mail.gmail.com>
[not found] ` <1382696677.4970.40.camel@dvhart-mobl4.amr.corp.intel.com>
2013-10-25 10:41 ` [gpio:for-next 67/67] pch_gbe_main.c:undefined reference to `devm_gpio_request_one' Linus Walleij
2013-10-25 10:49 ` Linus Walleij
2013-10-25 21:21 ` David Cohen [this message]
2013-10-25 21:25 ` David Cohen
[not found] ` <1382819615.23829.16.camel@dvhart-mobl4.amr.corp.intel.com>
2013-10-26 21:15 ` Darren Hart
2013-10-27 5:31 ` David Cohen
2013-10-28 0:04 ` Darren Hart
2013-10-28 18:01 ` David Cohen
2013-10-30 18:21 ` Linus Walleij
2013-10-31 19:12 ` David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526AE0EB.4020602@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=davem@davemloft.net \
--cc=dvhart@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).