From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH 1/2] octeon_mgmt: remove double validation of mac address Date: Tue, 29 Oct 2013 14:45:12 -0700 Message-ID: <52702C68.5060603@gmail.com> References: <1383082053-12405-1-git-send-email-laurent.navet@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, jiri@resnulli.us, david.daney@cavium.com, wfp5p@virginia.edu, gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Laurent Navet , Luka Perkov Return-path: In-Reply-To: <1383082053-12405-1-git-send-email-laurent.navet@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10/29/2013 02:27 PM, Laurent Navet wrote: > Mac address validity is already checked in of_get_mac_address(). > No need to do it twice. > > Signed-off-by: Laurent Navet Luka already sent this exact patch, and I acked his. No need to do it twice. David Daney > --- > drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c > index 622aa75..1b326cbc 100644 > --- a/drivers/net/ethernet/octeon/octeon_mgmt.c > +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c > @@ -1545,7 +1545,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev) > > mac = of_get_mac_address(pdev->dev.of_node); > > - if (mac && is_valid_ether_addr(mac)) > + if (mac) > memcpy(netdev->dev_addr, mac, ETH_ALEN); > else > eth_hw_addr_random(netdev); >