From: Ying Xue <ying.xue@windriver.com>
To: "David Laight" <David.Laight@ACULAB.COM>,
"Andreas Bofjäll" <andreas.bofjall@ericsson.com>,
"Erik Hugne" <erik.hugne@ericsson.com>
Cc: jon.maloy@ericsson.com, netdev@vger.kernel.org,
tipc-discussion@lists.sourceforge.net, davem@davemloft.net,
Paul.Gortmaker@windriver.com
Subject: Re: [PATCH net-next] tipc: remove two indentation levels in tipc_recv_msg routine
Date: Wed, 30 Oct 2013 09:34:57 +0800 [thread overview]
Message-ID: <52706241.60600@windriver.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B73BD@saturn3.aculab.com>
On 10/29/2013 08:42 PM, David Laight wrote:
>> continue;
>> +
>> +unlock:
>> + tipc_node_unlock(n_ptr);
>> cont:
>> kfree_skb(buf);
>> }
>
> Might be better to call the labels 'unlock_discard' and 'discard'.
>
Thanks for your valuable suggestions. I will submit next version soon.
Regards,
Ying
> David
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
prev parent reply other threads:[~2013-10-30 1:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 11:01 [PATCH net-next] tipc: remove two indentation levels in tipc_recv_msg routine Ying Xue
2013-10-29 11:13 ` David Laight
2013-10-29 12:07 ` Erik Hugne
2013-10-29 12:40 ` Andreas Bofjäll
2013-10-29 12:42 ` [tipc-discussion] " David Laight
2013-10-30 1:34 ` Ying Xue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52706241.60600@windriver.com \
--to=ying.xue@windriver.com \
--cc=David.Laight@ACULAB.COM \
--cc=Paul.Gortmaker@windriver.com \
--cc=andreas.bofjall@ericsson.com \
--cc=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).