From: Daniel Borkmann <dborkman@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Joe Perches <joe@perches.com>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/5] lib: crc32: clean up spacing in test cases
Date: Wed, 30 Oct 2013 15:15:29 +0100 [thread overview]
Message-ID: <52711481.8030003@redhat.com> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B73C8@saturn3.aculab.com>
On 10/30/2013 03:10 PM, David Laight wrote:
>>> + {0x674bf11d, 0x00000038, 0x00000542, 0x0af6d466, 0xd8b6e4c1, 0xf6e93d6c},
>>
>> these could be
>>
>> + {0x674bf11d, 0x38, 0x542, 0x0af6d466, 0xd8b6e4c1, 0xf6e93d6c},
>
> Or even:
> #define X(a, b, c, d, e, f) {0x##a, 0x##b, 0x##c, 0x##d, 0x##e. 0x##f}
> X(674bf11d, 38, 542, 0af6d466, d8b6e4c1, f6e93d6c),
> ...
> #undef X
Sure, sounds good to me. We could do that as a follow-up.
> David
>
>
>
next prev parent reply other threads:[~2013-10-30 14:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 10:50 [PATCH net-next 0/5] SCTP fix/updates Daniel Borkmann
2013-10-30 10:50 ` [PATCH net-next 1/5] lib: crc32: clean up spacing in test cases Daniel Borkmann
2013-10-30 13:56 ` Joe Perches
2013-10-30 14:10 ` David Laight
2013-10-30 14:15 ` Daniel Borkmann [this message]
2013-10-30 15:14 ` Joe Perches
2013-10-30 10:50 ` [PATCH net-next 2/5] lib: crc32: add functionality to combine two crc32{,c}s in GF(2) Daniel Borkmann
2013-10-30 10:50 ` [PATCH net-next 3/5] lib: crc32: add test cases for crc32{,c}_combine routines Daniel Borkmann
2013-10-30 10:50 ` [PATCH net-next 4/5] net: skb_checksum: allow custom update/combine for walking skb Daniel Borkmann
2013-10-30 10:50 ` [PATCH net-next 5/5] net: sctp: fix and consolidate SCTP checksumming code Daniel Borkmann
2013-10-30 14:29 ` Vlad Yasevich
2013-11-04 12:11 ` Daniel Borkmann
2013-11-04 16:10 ` Vlad Yasevich
2013-11-04 21:10 ` Daniel Borkmann
2013-10-30 11:29 ` [PATCH net-next 0/5] SCTP fix/updates Neil Horman
2013-10-30 14:29 ` Vlad Yasevich
2013-11-04 4:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52711481.8030003@redhat.com \
--to=dborkman@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).